[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZuAAbi7hRWz2DUte@smile.fi.intel.com>
Date: Tue, 10 Sep 2024 11:16:46 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Waiman Long <longman@...hat.com>
Cc: Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>,
Will Deacon <will.deacon@....com>,
Boqun Feng <boqun.feng@...il.com>, linux-kernel@...r.kernel.org,
llvm@...ts.linux.dev, Nathan Chancellor <nathan@...nel.org>,
Nick Desaulniers <ndesaulniers@...gle.com>,
Bill Wendling <morbo@...gle.com>,
Justin Stitt <justinstitt@...gle.com>
Subject: Re: [PATCH] locking/rwsem: Move is_rwsem_reader_owned() and
rwsem_owner() under CONFIG_DEBUG_RWSEMS
On Tue, Sep 10, 2024 at 11:15:54AM +0300, Andy Shevchenko wrote:
> On Mon, Sep 09, 2024 at 02:29:05PM -0400, Waiman Long wrote:
> > Both is_rwsem_reader_owned() and rwsem_owner() are currently only used when
> > CONFIG_DEBUG_RWSEMS is defined. This causes a compilation error with clang
> > when `make W=1` and CONFIG_WERROR=y:
> >
> > kernel/locking/rwsem.c:187:20: error: unused function 'is_rwsem_reader_owned' [-Werror,-Wunused-function]
> > 187 | static inline bool is_rwsem_reader_owned(struct rw_semaphore *sem)
> > | ^~~~~~~~~~~~~~~~~~~~~
> > kernel/locking/rwsem.c:271:35: error: unused function 'rwsem_owner' [-Werror,-Wunused-function]
> > 271 | static inline struct task_struct *rwsem_owner(struct rw_semaphore *sem)
> > | ^~~~~~~~~~~
> >
> > Fix this by moving these two functions under the CONFIG_DEBUG_RWSEMS define.
>
> At least this solves my issue,
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
...and
Tested-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
--
With Best Regards,
Andy Shevchenko
Powered by blists - more mailing lists