linux-kernel - RE: [PATCH 13/14] soundwire: mipi-disco: add new properties from 2.0 spec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <SJ2PR11MB8424DB4CC5F16B3D8FFAC8C9FF9A2@SJ2PR11MB8424.namprd11.prod.outlook.com>
Date: Tue, 10 Sep 2024 09:17:10 +0000
From: "Liao, Bard" <bard.liao@...el.com>
To: Charles Keepax <ckeepax@...nsource.cirrus.com>, Bard Liao
	<yung-chuan.liao@...ux.intel.com>
CC: "linux-sound@...r.kernel.org" <linux-sound@...r.kernel.org>,
	"vkoul@...nel.org" <vkoul@...nel.org>, "vinod.koul@...aro.org"
	<vinod.koul@...aro.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "pierre-louis.bossart@...ux.intel.com"
	<pierre-louis.bossart@...ux.intel.com>
Subject: RE: [PATCH 13/14] soundwire: mipi-disco: add new properties from 2.0
 spec



> -----Original Message-----
> From: Charles Keepax <ckeepax@...nsource.cirrus.com>
> Sent: Monday, September 9, 2024 11:06 PM
> To: Bard Liao <yung-chuan.liao@...ux.intel.com>
> Cc: linux-sound@...r.kernel.org; vkoul@...nel.org; vinod.koul@...aro.org;
> linux-kernel@...r.kernel.org; pierre-louis.bossart@...ux.intel.com; Liao, Bard
> <bard.liao@...el.com>
> Subject: Re: [PATCH 13/14] soundwire: mipi-disco: add new properties from
> 2.0 spec
> 
> On Tue, Aug 27, 2024 at 09:07:06PM +0800, Bard Liao wrote:
> > diff --git a/drivers/soundwire/mipi_disco.c
> b/drivers/soundwire/mipi_disco.c
> > index d6eb63bf1252..2215c53f95de 100644
> > --- a/drivers/soundwire/mipi_disco.c
> > +++ b/drivers/soundwire/mipi_disco.c
> > @@ -398,6 +398,19 @@ int sdw_slave_read_prop(struct sdw_slave *slave)
> >  	device_property_read_u32(dev, "mipi-sdw-sink-port-list",
> >  				 &prop->sink_ports);
> >
> > +	device_property_read_u32(dev, "mipi-sdw-sdca-interrupt-register-
> list",
> > +				 &prop->sdca_interrupt_register_list);
> > +
> > +	/*
> > +	 * The specification defines the property value as boolean, but
> > +	 * the value can be defined as zero. This is not aligned the
> > +	 * implementation of device_property_read_bool() which only checks
> > +	 * the presence of the property.
> > +	 * Let's use read_u8 to work-around this conceptual disconnect.
> > +	 */
> > +	device_property_read_u8(dev, "mipi-sdw-commit-register-
> supported",
> > +				&prop->commit_register_supported);
> 
> Would this not be a case for the new helper added earlier in the
> series? Or is this some third type of boolean?

Thanks Charles. Yes, we should use mipi_device_property_read_bool().
Will send a v2 to fix.

> 
> Thanks,
> Charles