linux-kernel - Re: [PATCH v6 0/7] Event parsing fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a87f5d39-0d61-4316-a2ab-01201f9d0ccd@linaro.org>
Date: Tue, 10 Sep 2024 10:27:15 +0100
From: James Clark <james.clark@...aro.org>
To: "Liang, Kan" <kan.liang@...ux.intel.com>, irogers@...gle.com,
 linux-perf-users@...r.kernel.org, ak@...ux.intel.com, namhyung@...nel.org
Cc: John Garry <john.g.garry@...cle.com>, Will Deacon <will@...nel.org>,
 Mike Leach <mike.leach@...aro.org>, Leo Yan <leo.yan@...ux.dev>,
 Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>,
 Arnaldo Carvalho de Melo <acme@...nel.org>,
 Mark Rutland <mark.rutland@....com>,
 Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
 Jiri Olsa <jolsa@...nel.org>, Adrian Hunter <adrian.hunter@...el.com>,
 Weilin Wang <weilin.wang@...el.com>,
 Athira Rajeev <atrajeev@...ux.vnet.ibm.com>,
 Dominique Martinet <asmadeus@...ewreck.org>,
 Yang Jihong <yangjihong@...edance.com>,
 Colin Ian King <colin.i.king@...il.com>, Howard Chu <howardchu95@...il.com>,
 Ze Gao <zegao2021@...il.com>, Jing Zhang <renyu.zj@...ux.alibaba.com>,
 Sun Haiyong <sunhaiyong@...ngson.cn>, Yicong Yang
 <yangyicong@...ilicon.com>, linux-arm-kernel@...ts.infradead.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 0/7] Event parsing fixes



On 9/5/24 19:20, Liang, Kan wrote:
> 
> 
> On 2024-09-03 6:19 a.m., James Clark wrote:
>> I rebased this one and made some other fixes so that I could test it,
>> so I thought I'd repost it here in case it's helpful. I also added a
>> new test.
>>
>> But for the testing it all looks ok.
>>
>> There is one small difference where it now hides _all_ default
>> <not supported> events, when previously it would only hide some
>> selected subset of events like "stalled-cycles-frontend". I think
>> this is now more consistent across platforms because, for example,
>> Apple M only has cycles and instructions, and the rest of the
>> default events would always show as <not supported> there.
>>
>> Tested on Raptor Lake, Kaby Lake, Juno, N1, Ampere (with the DSU
>> cycles PMU) and I also faked an Apple M on Juno.
>>
> 
> The tui mode in perf report is broken on Intel hybrid machine.
> 
> $perf record -e cycles,instructions sleep 1
> $perf report
> 
> Without the patch set, in the tui mode,
> Available samples
> 7 cpu_atom/cycles/
>                                       ◆
> 0 cpu_core/cycles/
>                                       ▒
> 7 cpu_atom/instructions/
>                                       ▒
> 0 cpu_core/instructions/
>                                       ▒
> 0 dummy:u
> 
> After applying the patch set,
> Available samples
> 7 /cycles/
>                                       ◆
> 0 /cycles/
>                                       ▒
> 7 /instructions/
>                                       ▒
> 0 /instructions/
>                                       ▒
> 0 dummy:u
> 
> 
> It looks something wrong with the uniquify_event_name().
> 
> Thanks,
> Kan
> 

Thanks, taking a look.