linux-kernel - Re: [net-next PATCH v2 2/4] octeontx2-pf: Add new APIs for queue memory alloc/free.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d58d7b9a-ae20-4c07-af17-425cbdfd861b@redhat.com>
Date: Tue, 10 Sep 2024 11:41:11 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Geetha sowjanya <gakula@...vell.com>, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org
Cc: kuba@...nel.org, davem@...emloft.net, jiri@...nulli.us,
 edumazet@...gle.com, sgoutham@...vell.com, sbhatta@...vell.com,
 hkelam@...vell.com
Subject: Re: [net-next PATCH v2 2/4] octeontx2-pf: Add new APIs for queue
 memory alloc/free.

On 9/5/24 11:49, Geetha sowjanya wrote:
> Group the queue(RX/TX/CQ) memory allocation and free code to single APIs.
> 
> Signed-off-by: Geetha sowjanya <gakula@...vell.com>
> ---
>   .../marvell/octeontx2/nic/otx2_common.h       |  2 +
>   .../ethernet/marvell/octeontx2/nic/otx2_pf.c  | 54 +++++++++++++------
>   2 files changed, 40 insertions(+), 16 deletions(-)
> 
> diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h
> index a47001a2b93f..df548aeffecf 100644
> --- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h
> +++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h
> @@ -997,6 +997,8 @@ int otx2_pool_init(struct otx2_nic *pfvf, u16 pool_id,
>   int otx2_aura_init(struct otx2_nic *pfvf, int aura_id,
>   		   int pool_id, int numptrs);
>   int otx2_init_rsrc(struct pci_dev *pdev, struct otx2_nic *pf);
> +void otx2_free_queue_mem(struct otx2_qset *qset);
> +int otx2_alloc_queue_mem(struct otx2_nic *pf);
>   
>   /* RSS configuration APIs*/
>   int otx2_rss_init(struct otx2_nic *pfvf);
> diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c
> index 4cfeca5ca626..6dfd6d1064ad 100644
> --- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c
> +++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c
> @@ -1770,15 +1770,23 @@ static void otx2_dim_work(struct work_struct *w)
>   	dim->state = DIM_START_MEASURE;
>   }
>   
> -int otx2_open(struct net_device *netdev)
> +void otx2_free_queue_mem(struct otx2_qset *qset)
> +{
> +	kfree(qset->sq);
> +	qset->sq = NULL;
> +	kfree(qset->cq);
> +	qset->cq = NULL;
> +	kfree(qset->rq);
> +	qset->rq = NULL;
> +	kfree(qset->napi);

It's strange that the napi ptr is not reset here. You should add a 
comment describing the reason or zero such field, too.

Thanks,

Paolo