[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <01020191db57a3d1-2c076978-c7c0-4685-9621-10ecdc3c5e99-000000@eu-west-1.amazonses.com>
Date: Tue, 10 Sep 2024 09:50:39 +0000
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
To: Chen-Yu Tsai <wenst@...omium.org>
Cc: chunkuang.hu@...nel.org, robh@...nel.org,
krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
p.zabel@...gutronix.de, airlied@...il.com, daniel@...ll.ch,
maarten.lankhorst@...ux.intel.com, mripard@...nel.org,
tzimmermann@...e.de, matthias.bgg@...il.com, shawn.sung@...iatek.com,
yu-chang.lee@...iatek.com, ck.hu@...iatek.com,
jitao.shi@...iatek.com, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org,
linux-mediatek@...ts.infradead.org,
linux-arm-kernel@...ts.infradead.org, kernel@...labora.com,
sui.jingfeng@...ux.dev, michael@...le.cc, sjoerd@...labora.com
Subject: Re: [PATCH v9 0/3] drm/mediatek: Add support for OF graphs
Il 10/09/24 11:39, Chen-Yu Tsai ha scritto:
> On Tue, Sep 10, 2024 at 5:01 PM AngeloGioacchino Del Regno
> <angelogioacchino.delregno@...labora.com> wrote:
>>
>> Changes in v9:
>> - Rebased on next-20240910
>> - Removed redundant assignment and changed a print to dev_err()
>> - Dropped if branch to switch conversion as requested; this will
>> be sent as a separate commit out of this series.
>>
>> Changes in v8:
>> - Rebased on next-20240617
>> - Changed to allow probing a VDO with no available display outputs
>>
>> Changes in v7:
>> - Fix typo in patch 3/3
>>
>> Changes in v6:
>> - Added EPROBE_DEFER check to fix dsi/dpi false positive DT fallback case
>> - Dropped refcount of ep_out in mtk_drm_of_get_ddp_ep_cid()
>> - Fixed double refcount drop during path building
>> - Removed failure upon finding a DT-disabled path as requested
>> - Tested again on MT8195, MT8395 boards
>>
>> Changes in v5:
>> - Fixed commit [2/3], changed allOf -> anyOf to get the
>> intended allowance in the binding
>>
>> Changes in v4:
>> - Fixed a typo that caused pure OF graphs pipelines multiple
>> concurrent outputs to not get correctly parsed (port->id);
>> - Added OVL_ADAPTOR support for OF graph specified pipelines;
>> - Now tested with fully OF Graph specified pipelines on MT8195
>> Chromebooks and MT8395 boards;
>> - Rebased on next-20240516
>>
>> Changes in v3:
>> - Rebased on next-20240502 because of renames in mediatek-drm
>>
>> Changes in v2:
>> - Fixed wrong `required` block indentation in commit [2/3]
>>
>>
>> The display IPs in MediaTek SoCs are *VERY* flexible and those support
>> being interconnected with different instances of DDP IPs (for example,
>> merge0 or merge1) and/or with different DDP IPs (for example, rdma can
>> be connected with either color, dpi, dsi, merge, etc), forming a full
>> Display Data Path that ends with an actual display.
>>
>> This series was born because of an issue that I've found while enabling
>> support for MT8195/MT8395 boards with DSI output as main display: the
>> current mtk_drm_route variations would not work as currently, the driver
>> hardcodes a display path for Chromebooks, which have a DisplayPort panel
>> with DSC support, instead of a DSI panel without DSC support.
>>
>> There are other reasons for which I wrote this series, and I find that
>> hardcoding those paths - when a HW path is clearly board-specific - is
>> highly suboptimal. Also, let's not forget about keeping this driver from
>> becoming a huge list of paths for each combination of SoC->board->disp
>> and... this and that.
>>
>> For more information, please look at the commit description for each of
>> the commits included in this series.
>>
>> This series is essential to enable support for the MT8195/MT8395 EVK,
>> Kontron i1200, Radxa NIO-12L and, mainly, for non-Chromebook boards
>> and Chromebooks to co-exist without conflicts.
>>
>> Besides, this is also a valid option for MT8188 Chromebooks which might
>> have different DSI-or-eDP displays depending on the model (as far as I
>> can see from the mtk_drm_route attempt for this SoC that is already
>> present in this driver).
>>
>> This series was tested on MT8195 Cherry Tomato and on MT8395 Radxa
>> NIO-12L with both hardcoded paths, OF graph support and partially
>> hardcoded paths, and pure OF graph support including pipelines that
>> require OVL_ADAPTOR support.
>>
>> AngeloGioacchino Del Regno (3):
>> dt-bindings: display: mediatek: Add OF graph support for board path
>> dt-bindings: arm: mediatek: mmsys: Add OF graph support for board path
>> drm/mediatek: Implement OF graphs support for display paths
>>
>> .../bindings/arm/mediatek/mediatek,mmsys.yaml | 28 ++
>> .../arm/mediatek/mediatek,mmsys.yaml.orig | 140 ++++++++++
>> .../display/mediatek/mediatek,aal.yaml | 40 +++
>> .../display/mediatek/mediatek,aal.yaml.orig | 93 +++++++
>> .../display/mediatek/mediatek,ccorr.yaml | 21 ++
>> .../display/mediatek/mediatek,ccorr.yaml.orig | 88 ++++++
>> .../display/mediatek/mediatek,color.yaml | 22 ++
>> .../display/mediatek/mediatek,color.yaml.orig | 96 +++++++
>> .../display/mediatek/mediatek,dither.yaml | 22 ++
>> .../mediatek/mediatek,dither.yaml.orig | 87 ++++++
>> .../display/mediatek/mediatek,dpi.yaml | 25 +-
>> .../display/mediatek/mediatek,dpi.yaml.orig | 122 +++++++++
>> .../display/mediatek/mediatek,dsc.yaml | 24 ++
>> .../display/mediatek/mediatek,dsi.yaml | 27 +-
>> .../display/mediatek/mediatek,dsi.yaml.orig | 126 +++++++++
>> .../display/mediatek/mediatek,ethdr.yaml | 22 ++
>> .../display/mediatek/mediatek,gamma.yaml | 19 ++
>> .../display/mediatek/mediatek,gamma.yaml.orig | 96 +++++++
>> .../display/mediatek/mediatek,merge.yaml | 23 ++
>> .../display/mediatek/mediatek,merge.yaml.orig | 110 ++++++++
>> .../display/mediatek/mediatek,od.yaml | 22 ++
>> .../display/mediatek/mediatek,ovl-2l.yaml | 22 ++
>> .../mediatek/mediatek,ovl-2l.yaml.orig | 78 ++++++
>> .../display/mediatek/mediatek,ovl.yaml | 22 ++
>> .../display/mediatek/mediatek,ovl.yaml.orig | 109 ++++++++
>> .../display/mediatek/mediatek,postmask.yaml | 21 ++
>> .../display/mediatek/mediatek,rdma.yaml | 22 ++
>> .../display/mediatek/mediatek,rdma.yaml.orig | 122 +++++++++
>> .../display/mediatek/mediatek,ufoe.yaml | 21 ++
>> .../display/mediatek/mediatek,wdma.yaml.orig | 76 ++++++
>> .../bindings/gpu/arm,mali-bifrost.yaml.orig | 250 +++++++++++++++++
>> .../bindings/leds/leds-mt6323.txt.orig | 60 +++++
>> .../bindings/ufs/mediatek,ufs.yaml.orig | 71 +++++
>> drivers/gpu/drm/mediatek/mtk_disp_drv.h | 1 +
>> .../gpu/drm/mediatek/mtk_disp_ovl_adaptor.c | 40 ++-
>> drivers/gpu/drm/mediatek/mtk_dpi.c | 21 +-
>> drivers/gpu/drm/mediatek/mtk_drm_drv.c | 253 +++++++++++++++++-
>> drivers/gpu/drm/mediatek/mtk_drm_drv.h | 2 +-
>> drivers/gpu/drm/mediatek/mtk_dsi.c | 14 +-
>> 39 files changed, 2433 insertions(+), 25 deletions(-)
>> create mode 100644 Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.yaml.orig
>> create mode 100644 Documentation/devicetree/bindings/display/mediatek/mediatek,aal.yaml.orig
>> create mode 100644 Documentation/devicetree/bindings/display/mediatek/mediatek,ccorr.yaml.orig
>> create mode 100644 Documentation/devicetree/bindings/display/mediatek/mediatek,color.yaml.orig
>> create mode 100644 Documentation/devicetree/bindings/display/mediatek/mediatek,dither.yaml.orig
>> create mode 100644 Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml.orig
>> create mode 100644 Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.yaml.orig
>> create mode 100644 Documentation/devicetree/bindings/display/mediatek/mediatek,gamma.yaml.orig
>> create mode 100644 Documentation/devicetree/bindings/display/mediatek/mediatek,merge.yaml.orig
>> create mode 100644 Documentation/devicetree/bindings/display/mediatek/mediatek,ovl-2l.yaml.orig
>> create mode 100644 Documentation/devicetree/bindings/display/mediatek/mediatek,ovl.yaml.orig
>> create mode 100644 Documentation/devicetree/bindings/display/mediatek/mediatek,rdma.yaml.orig
>> create mode 100644 Documentation/devicetree/bindings/display/mediatek/mediatek,wdma.yaml.orig
>> create mode 100644 Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml.orig
>> create mode 100644 Documentation/devicetree/bindings/leds/leds-mt6323.txt.orig
>> create mode 100644 Documentation/devicetree/bindings/ufs/mediatek,ufs.yaml.orig
>
> It looks like you accidentally imported a bunch of files from Git.
>
Ouch. Yeah, looks like I did.
Will send a v10 soon, I apparently need some coffee :-P
Thanks,
Angelo
> ChenYu
>
>>
>> --
>> 2.46.0
>>
Powered by blists - more mailing lists