linux-kernel - Re: [PATCH v5 02/12] dt-bindings: usb: ti,j721e-usb: add ti,j7200-usb compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <D42IONMJMLQS.37KAIQ5GKLRTU@bootlin.com>
Date: Tue, 10 Sep 2024 12:03:35 +0200
From: Théo Lebrun <theo.lebrun@...tlin.com>
To: "Rob Herring (Arm)" <robh@...nel.org>
Cc: "Mathias Nyman" <mathias.nyman@...el.com>, <linux-usb@...r.kernel.org>,
 "Krzysztof Kozlowski" <krzk+dt@...nel.org>, "Kevin Hilman"
 <khilman@...nel.org>, Grégory Clement
 <gregory.clement@...tlin.com>, <devicetree@...r.kernel.org>, "Tero Kristo"
 <kristo@...nel.org>, <linux-kernel@...r.kernel.org>, "Greg Kroah-Hartman"
 <gregkh@...uxfoundation.org>, <linux-arm-kernel@...ts.infradead.org>,
 "Nishanth Menon" <nm@...com>, "Vignesh Raghavendra" <vigneshr@...com>,
 "Pawel Laszczak" <pawell@...ence.com>, "Thomas Petazzoni"
 <thomas.petazzoni@...tlin.com>, "Roger Quadros" <rogerq@...nel.org>, "Peter
 Chen" <peter.chen@...nel.org>, "Conor Dooley" <conor+dt@...nel.org>
Subject: Re: [PATCH v5 02/12] dt-bindings: usb: ti,j721e-usb: add
 ti,j7200-usb compatible

On Fri Jul 26, 2024 at 9:26 PM CEST, Rob Herring (Arm) wrote:
> On Fri, 26 Jul 2024 20:17:50 +0200, Théo Lebrun wrote:
> > On J7200, the controller & its wrapper are reset on resume. It has the
> > same behavior as ti,j721e-usb with a different SoC integration.
> > 
> > Signed-off-by: Théo Lebrun <theo.lebrun@...tlin.com>
> > ---
> >  Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> > 
>
> My bot found errors running 'make dt_binding_check' on your patch:

Clearly this patch was wrong.
Past me trusted future me to verify and future me trusted past me.
Sorry!

For reference, new patch content will look like below.
This doesn't trigger a warning on:

    make dt_binding_check DT_SCHEMA_FILES=ti,j721e-usb

------------------------------------------------------------------------

diff --git a/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml b/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml
index 653a89586f4e..d14c18b64086 100644
--- a/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml
+++ b/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml
@@ -14,7 +14,9 @@ properties:
     oneOf:
       - const: ti,j721e-usb
       - items:
-          - const: ti,am64-usb
+          - enum:
+              - ti,am64-usb
+              - ti,j7200-usb
           - const: ti,j721e-usb

   reg:

------------------------------------------------------------------------

Regards,

--
Théo Lebrun, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com