linux-kernel - Re: [PATCH] platform: cznic: turris-omnia-mcu: fix HW

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <nby5jsvn5mkj2jubbhvlxris7vxh7lwzey466atthhyq6k2gpq@qtpu4vu67q57>
Date: Tue, 10 Sep 2024 12:09:15 +0200
From: Marek Behún <kabel@...nel.org>
To: Arnd Bergmann <arnd@...nel.org>
Cc: soc@...nel.org, Marek Behún <kabel@...nel.org>, 
	Arnd Bergmann <arnd@...db.de>, Bartosz Golaszewski <bartosz.golaszewski@...aro.org>, 
	Andy Shevchenko <andy@...nel.org>, Guenter Roeck <linux@...ck-us.net>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] platform: cznic: turris-omnia-mcu: fix HW_RANDOM
 dependency

Reviewed-by: Marek Behún <kabel@...nel.org>

On Mon, Sep 09, 2024 at 11:04:09AM +0000, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> There is still a build failure when the rwrng support is in a loadable
> module but the mcu driver is built-in:
> 
> arm-linux-gnueabi-ld: drivers/platform/cznic/turris-omnia-mcu-trng.o: in function `omnia_mcu_register_trng':
> turris-omnia-mcu-trng.c:(.text.omnia_mcu_register_trng+0x11c): undefined reference to `devm_hwrng_register'
> 
> Change the dependency to explicitly disallow the broken
> configuration.
> 
> Fixes: 41bb142a4028 ("platform: cznic: turris-omnia-mcu: Add support for MCU provided TRNG")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  drivers/platform/cznic/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/cznic/Kconfig b/drivers/platform/cznic/Kconfig
> index a111eca8ff57..49c383eb6785 100644
> --- a/drivers/platform/cznic/Kconfig
> +++ b/drivers/platform/cznic/Kconfig
> @@ -70,7 +70,7 @@ config TURRIS_OMNIA_MCU_TRNG
>  	bool "Turris Omnia MCU true random number generator"
>  	default y
>  	depends on TURRIS_OMNIA_MCU_GPIO
> -	depends on HW_RANDOM
> +	depends on HW_RANDOM=y || HW_RANDOM=TURRIS_OMNIA_MCU
>  	help
>  	  Say Y here to add support for the true random number generator
>  	  provided by CZ.NIC's Turris Omnia MCU.
> -- 
> 2.39.2
>