[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240910102531.grjtn2rdmagcgphb@localhost.localdomain>
Date: Tue, 10 Sep 2024 13:25:31 +0300
From: "Ivan T. Ivanov" <iivanov@...e.de>
To: Corey Minyard <corey@...yard.net>
Cc: openipmi-developer@...ts.sourceforge.net, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ipmi:ssif: Improve detecting during probing
Hi Corey,
On 08-20 20:05, Corey Minyard wrote:
>
> If an IPMI SSIF device is probed and there is something there, but
> probably not an actual BMC, the code would just issue a lot of errors
> before it failed. We kind of need these errors to help with certain
> issues, and some of the failure reports are non-fatal.
>
> However, a get device id command should alway work. If that fails,
> nothing else is going to work and it's a pretty good indication that
> there's no valid BMC there. So issue and check that command and bail
> if it fails.
>
> Reported-by: Ivan T. Ivanov <iivanov@...e.de>
> Signed-off-by: Corey Minyard <corey@...yard.net>
> ---
> drivers/char/ipmi/ipmi_ssif.c | 24 +++++++++++++++++++++++-
> 1 file changed, 23 insertions(+), 1 deletion(-)
Do you plan to merge this fix?
Regards,
Ivan
Powered by blists - more mailing lists