[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <6d0198fc-02ba-4681-8332-b6c8424eec59@redhat.com>
Date: Tue, 10 Sep 2024 12:24:26 +0200
From: Paolo Bonzini <pbonzini@...hat.com>
To: Rick Edgecombe <rick.p.edgecombe@...el.com>, seanjc@...gle.com,
kvm@...r.kernel.org
Cc: kai.huang@...el.com, dmatlack@...gle.com, isaku.yamahata@...il.com,
yan.y.zhao@...el.com, nik.borisov@...e.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 16/21] KVM: TDX: Premap initial guest memory
On 9/4/24 05:07, Rick Edgecombe wrote:
> +static int tdx_mem_page_record_premap_cnt(struct kvm *kvm, gfn_t gfn,
> + enum pg_level level, kvm_pfn_t pfn)
> +{
> + struct kvm_tdx *kvm_tdx = to_kvm_tdx(kvm);
> +
> + /* Returning error here to let TDP MMU bail out early. */
> + if (KVM_BUG_ON(level != PG_LEVEL_4K, kvm)) {
> + tdx_unpin(kvm, pfn);
> + return -EINVAL;
> + }
Should this "if" already be part of patch 14, and in
tdx_sept_set_private_spte() rather than tdx_mem_page_record_premap_cnt()?
Thanks,
Paolo
Powered by blists - more mailing lists