linux-kernel - Re: [PATCH v4 3/3] i2c: jz4780: Use dev_err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2557612f-5990-44ad-8a36-95a6f6a7f230@vivo.com>
Date: Tue, 10 Sep 2024 10:06:16 +0800
From: Rong Qianfeng <11065417@...o.com>
To: Andi Shyti <andi.shyti@...nel.org>
Cc: andriy.shevchenko@...el.com, biju.das.jz@...renesas.com,
 Wolfram Sang <wsa+renesas@...g-engineering.com>,
 Paul Cercueil <paul@...pouillou.net>, linux-renesas-soc@...r.kernel.org,
 linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-mips@...r.kernel.org, opensource.kernel@...o.com,
 Rong Qianfeng <rongqianfeng@...o.com>
Subject: Re: [PATCH v4 3/3] i2c: jz4780: Use dev_err_probe()

Hi Andi,

在 2024/9/10 3:24, Andi Shyti 写道:
> On Mon, Sep 09, 2024 at 04:58:10PM GMT, Rong Qianfeng wrote:
>>> I'm not a big fan of this change. There is not much gain in
>>> polluting git bisect in order to shorten pdev->dev to a single
>>> dev.
>>>
>>> However, I like the /dev_err/dev_err_probe/.
>>>
>>> I will take the first two patches from this series, but I will
>>> leave this if anyone else has a stronger opinion. If you want,
>>> you can send just this one patch with just the dev_err_probe()
>>> change.
>> Thanks for taking the time to review my patch!
>> Please take the first two patches, I don't plan to submit another
>> patch that only modifies dev_err().
> Sorry, I forgot to write it, I merged the first two in
> i2c/i2c-host.
>
> If you want to send one to change dev_err with dev_err_probe
> separately I will take it.

ok, I got it, thanks.

Best Regards,
Qianfeng