linux-kernel - Re: [PATCH] ipmi:ssif: Improve detecting during probing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240910120510.62h76nzr7lu7qdvn@localhost.localdomain>
Date: Tue, 10 Sep 2024 15:05:10 +0300
From: "Ivan T. Ivanov" <iivanov@...e.de>
To: Corey Minyard <corey@...yard.net>
Cc: openipmi-developer@...ts.sourceforge.net, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ipmi:ssif: Improve detecting during probing

On 09-10 06:30, Corey Minyard wrote:
> > >
> > > If an IPMI SSIF device is probed and there is something there, but
> > > probably not an actual BMC, the code would just issue a lot of errors
> > > before it failed.  We kind of need these errors to help with certain
> > > issues, and some of the failure reports are non-fatal.
> > >
> > > However, a get device id command should alway work.  If that fails,
> > > nothing else is going to work and it's a pretty good indication that
> > > there's no valid BMC there.  So issue and check that command and bail
> > > if it fails.
> > >
> > > Reported-by: Ivan T. Ivanov <iivanov@...e.de>
> > > Signed-off-by: Corey Minyard <corey@...yard.net>
> > > ---
> > >  drivers/char/ipmi/ipmi_ssif.c | 24 +++++++++++++++++++++++-
> > >  1 file changed, 23 insertions(+), 1 deletion(-)
> >
> > Do you plan to merge this fix?
> 
> Yes, it's queued for the next release window.  I should have responded
> with that.
> 

Thank you! No worries.

Regards,
Ivan