linux-kernel - Re: [PATCH v2 rdma-next] RDMA: Use ERR_CAST to return an error-valued pointer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240910122345.GZ4026@unreal>
Date: Tue, 10 Sep 2024 15:23:45 +0300
From: Leon Romanovsky <leon@...nel.org>
To: Yu Jiaoliang <yujiaoliang@...o.com>
Cc: Jason Gunthorpe <jgg@...pe.ca>,
	Mustafa Ismail <mustafa.ismail@...el.com>,
	Tatyana Nikolova <tatyana.e.nikolova@...el.com>,
	Erick Archer <erick.archer@....com>,
	Akiva Goldberger <agoldberger@...dia.com>,
	Patrisious Haddad <phaddad@...dia.com>,
	Max Gurtovoy <mgurtovoy@...dia.com>,
	Or Har-Toov <ohartoov@...dia.com>,
	Rohit Chavan <roheetchavan@...il.com>,
	Shigeru Yoshida <syoshida@...hat.com>, linux-rdma@...r.kernel.org,
	linux-kernel@...r.kernel.org, opensource.kernel@...o.com
Subject: Re: [PATCH v2 rdma-next] RDMA: Use ERR_CAST to return an
 error-valued pointer

On Fri, Sep 06, 2024 at 02:21:36PM +0800, Yu Jiaoliang wrote:
> Instead of directly casting and returning an error-valued pointer,
> use ERR_CAST to make the error handling more explicit and improve
> code clarity.
> 
> Signed-off-by: Yu Jiaoliang <yujiaoliang@...o.com>
> ---
> v2:
> - Additional modifications in file /drivers/infiniband/hw/irdma/verbs.c
> v1: https://lore.kernel.org/all/20240905110615.GU4026@unreal/
> ---
>  drivers/infiniband/core/mad_rmpp.c   | 2 +-
>  drivers/infiniband/core/uverbs_cmd.c | 2 +-
>  drivers/infiniband/core/verbs.c      | 2 +-
>  drivers/infiniband/hw/irdma/verbs.c  | 4 ++--
>  4 files changed, 5 insertions(+), 5 deletions(-)

It is still incomplete.
Something like that will give you a better result:
➜  kernel git:(wip/leon-for-next) git grep "return (" drivers/infiniband/ | grep "\*"

Thanks