[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <3ac91ab3-6f9a-4d88-9545-408a8fa0bf30@amlogic.com>
Date: Tue, 10 Sep 2024 10:22:46 +0800
From: Keke Li <keke.li@...ogic.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Mauro Carvalho Chehab <mchehab@...nel.org>, Rob Herring
<robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>, linux-media@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
kieran.bingham@...asonboard.com, laurent.pinchart@...asonboard.com,
dan.scally@...asonboard.com
Subject: Re: [PATCH v2 5/9] dt-bindings: media: Add amlogic,c3-isp.yaml
Hi Krzysztof,
Thanks for your reply.
On 2024/9/9 18:15, Krzysztof Kozlowski wrote:
> [ EXTERNAL EMAIL ]
>
> On Mon, Sep 09, 2024 at 03:24:15PM +0800, Keke Li wrote:
>> c3-isp is used to process raw image.
>>
>> Signed-off-by: Keke Li <keke.li@...ogic.com>
>> ---
>> .../devicetree/bindings/media/amlogic,c3-isp.yaml | 98 ++++++++++++++++++++++
>> 1 file changed, 98 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/media/amlogic,c3-isp.yaml b/Documentation/devicetree/bindings/media/amlogic,c3-isp.yaml
>> new file mode 100644
>> index 000000000000..dfa439cdc380
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/media/amlogic,c3-isp.yaml
>> @@ -0,0 +1,98 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/media/amlogic,c3-isp.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Amlogic C3 Image Signal Processing Unit
>> +
>> +maintainers:
>> + - Keke Li <keke.li@...ogic.com>
>> +
>> +description:
>> + Amlogic ISP is the RAW image processing module
>> + and supports three channels image output.
>> +
>> +properties:
>> + compatible:
>> + enum:
>> + - amlogic,c3-isp
>> +
>> + reg:
>> + maxItems: 1
>> +
>> + reg-names:
>> + items:
>> + - const: isp
>> +
>> + power-domains:
>> + maxItems: 1
>> +
>> + clocks:
>> + maxItems: 2
>> +
>> + clock-names:
>> + items:
>> + - const: vapb
>> + - const: isp0
>> +
>> + interrupts:
>> + maxItems: 1
>> +
>> + ports:
>> + $ref: /schemas/graph.yaml#/properties/ports
>> +
> Only one port? Then use "port" instead of "ports".
Yes, it has only one port.
I will use "port" instead of "ports".
Thanks again.
>
> Best regards,
> Krzysztof
>
Powered by blists - more mailing lists