[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240910124314.698896-1-ruanjinjie@huawei.com>
Date: Tue, 10 Sep 2024 20:43:11 +0800
From: Jinjie Ruan <ruanjinjie@...wei.com>
To: <chunkeey@...glemail.com>, <kvalo@...nel.org>, <briannorris@...omium.org>,
<francesco@...cini.it>, <krzysztof.kozlowski@...aro.org>,
<leitao@...ian.org>, <linville@...driver.com>, <rajatja@...gle.com>,
<linux-wireless@...r.kernel.org>, <linux-kernel@...r.kernel.org>
CC: <ruanjinjie@...wei.com>
Subject: [PATCH wireless v2 0/3] wifi: Use IRQF_NO_AUTOEN flag in request_irq()
As commit cbe16f35bee6 ("genirq: Add IRQF_NO_AUTOEN for request_irq/nmi()")
said, reqeust_irq() and then disable_irq() is unsafe.
And the code below is subobtimal:
irq_set_status_flags(irq, IRQ_NOAUTOEN);
request_irq(dev, irq...);
IRQF_NO_AUTOEN flag can be used by drivers to request_irq(). It prevents
the automatic enabling of the requested interrupt in the same safe way.
With that the usage can be simplified and corrected.
Only compile-tested.
Changes in v2:
- wireless prefixed subject and submit them in a separate patchset.
- Add fix tag.
Jinjie Ruan (3):
wifi: p54: Use IRQF_NO_AUTOEN flag in request_irq()
wifi: mwifiex: Use IRQF_NO_AUTOEN flag in request_irq()
wifi: wl1251: Use IRQF_NO_AUTOEN flag in request_irq()
drivers/net/wireless/intersil/p54/p54spi.c | 4 +---
drivers/net/wireless/marvell/mwifiex/main.c | 4 ++--
drivers/net/wireless/ti/wl1251/sdio.c | 4 ++--
3 files changed, 5 insertions(+), 7 deletions(-)
--
2.34.1
Powered by blists - more mailing lists