linux-kernel - [PATCH] clk: actions: prevent overflow in owl_pll_recalc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20240910130640.20631-1-abelova@astralinux.ru>
Date: Tue, 10 Sep 2024 16:06:40 +0300
From: Anastasia Belova <abelova@...ralinux.ru>
To: Michael Turquette <mturquette@...libre.com>
Cc: Anastasia Belova <abelova@...ralinux.ru>,
	Stephen Boyd <sboyd@...nel.org>,
	Andreas Färber <afaerber@...e.de>,
	Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
	linux-clk@...r.kernel.org (open list:COMMON CLK FRAMEWORK),
	linux-arm-kernel@...ts.infradead.org (moderated list:ARM/ACTIONS SEMI ARCHITECTURE),
	linux-actions@...ts.infradead.org (moderated list:ARM/ACTIONS SEMI ARCHITECTURE),
	linux-kernel@...r.kernel.org (open list),
	lvc-project@...uxtesting.org,
	stable@...r.kernel.org
Subject: [PATCH] clk: actions: prevent overflow in owl_pll_recalc_rate

In case of OWL S900 SoC clock driver there are cases
where bfreq = 24000000, shift = 0. If value read from
CMU_COREPLL or CMU_DDRPLL to val is big enough, an
overflow may occur.

Add explicit casting to prevent it.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: 2792c37e94c8 ("clk: actions: Add pll clock support")
Cc: <stable@...r.kernel.org> 
Signed-off-by: Anastasia Belova <abelova@...ralinux.ru>
---
 drivers/clk/actions/owl-pll.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/actions/owl-pll.c b/drivers/clk/actions/owl-pll.c
index 155f313986b4..fa17567665ec 100644
--- a/drivers/clk/actions/owl-pll.c
+++ b/drivers/clk/actions/owl-pll.c
@@ -104,7 +104,7 @@ static unsigned long owl_pll_recalc_rate(struct clk_hw *hw,
 	val = val >> pll_hw->shift;
 	val &= mul_mask(pll_hw);
 
-	return pll_hw->bfreq * val;
+	return (unsigned long)pll_hw->bfreq * val;
 }
 
 static int owl_pll_is_enabled(struct clk_hw *hw)
-- 
2.30.2