linux-kernel - [PATCH v1] cleanup: Remove extra semicolon when call DEFINE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID:
 <SY7P300MB0622292694BE714CB9990755E49B2@SY7P300MB0622.AUSP300.PROD.OUTLOOK.COM>
Date: Wed, 11 Sep 2024 21:35:30 +0800
From: Haiyue Wang <haiyue.wang@...look.com>
To: linux-kernel@...r.kernel.org
Cc: Haiyue Wang <haiyue.wang@...look.com>,
	Ingo Molnar <mingo@...nel.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Alexander Mikhalitsyn <alexander@...alicyn.com>,
	Josef Bacik <josef@...icpanda.com>,
	Christian Brauner <brauner@...nel.org>
Subject: [PATCH v1] cleanup: Remove extra semicolon when call DEFINE_CLASS()

The DEFINE_GUARD() adds one more semicolon to call DEFINE_CLASS(), it
expands ';' at the end of function 'class_##_name##_constructor'.

A nit fix, like DEFINE_GUARD_COND() calls EXTEND_CLASS() without ';',
to make code generation clean.

Signed-off-by: Haiyue Wang <haiyue.wang@...look.com>
---
 include/linux/cleanup.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/cleanup.h b/include/linux/cleanup.h
index d9e613803df1..abb1d9fd7a99 100644
--- a/include/linux/cleanup.h
+++ b/include/linux/cleanup.h
@@ -152,7 +152,7 @@ static inline class_##_name##_t class_##_name##ext##_constructor(_init_args) \
  */
 
 #define DEFINE_GUARD(_name, _type, _lock, _unlock) \
-	DEFINE_CLASS(_name, _type, if (_T) { _unlock; }, ({ _lock; _T; }), _type _T); \
+	DEFINE_CLASS(_name, _type, if (_T) { _unlock; }, ({ _lock; _T; }), _type _T) \
 	static inline void * class_##_name##_lock_ptr(class_##_name##_t *_T) \
 	{ return *_T; }
 
-- 
2.46.0