linux-kernel - Re: [PATCH 2/2] selftests: vDSO: fix vdso

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZuGeXMeRPoeuqz66@zx2c4.com>
Date: Wed, 11 Sep 2024 15:42:52 +0200
From: "Jason A. Donenfeld" <Jason@...c4.com>
To: Heiko Carstens <hca@...ux.ibm.com>
Cc: Shuah Khan <shuah@...nel.org>,
	Alexander Gordeev <agordeev@...ux.ibm.com>,
	Vasily Gorbik <gor@...ux.ibm.com>,
	Jens Remus <jremus@...ux.ibm.com>, linux-kernel@...r.kernel.org,
	linux-kselftest@...r.kernel.org, linux-s390@...r.kernel.org
Subject: Re: [PATCH 2/2] selftests: vDSO: fix vdso_config for s390

On Wed, Sep 11, 2024 at 10:50:15AM +0200, Heiko Carstens wrote:
> Running vdso_test_correctness on s390x (aka s390 64 bit) emits a warning:
> 
> Warning: failed to find clock_gettime64 in vDSO
> 
> This is caused by the "#elif defined (__s390__)" check in vdso_config.h
> which the defines VDSO_32BIT.
> 
> If __s390x__ is defined also __s390__ is defined. Therefore the correct
> check must make sure that only __s390__ is defined.
> 
> Therefore add the missing !defined(__s390x__). Also use common
> __s390x__ define instead of __s390X__.
> 
> Signed-off-by: Heiko Carstens <hca@...ux.ibm.com>

I'll add to it:

    Fixes: 693f5ca08ca0 ("kselftest: Extend vDSO selftest")