linux-kernel - Re: [PATCH v2 -next 00/11] Add PCIe support for bcm2712

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <172606223862.90488.9381766906097869924.robh@kernel.org>
Date: Wed, 11 Sep 2024 08:50:05 -0500
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Stanimir Varbanov <svarbanov@...e.de>
Cc: linux-rpi-kernel@...ts.infradead.org, 
 Florian Fainelli <florian.fainelli@...adcom.com>, 
 Lorenzo Pieralisi <lpieralisi@...nel.org>, linux-kernel@...r.kernel.org, 
 Philipp Zabel <p.zabel@...gutronix.de>, 
 Jonathan Bell <jonathan@...pberrypi.com>, 
 Nicolas Saenz Julienne <nsaenz@...nel.org>, 
 Thomas Gleixner <tglx@...utronix.de>, Conor Dooley <conor+dt@...nel.org>, 
 Jim Quinlan <jim2101024@...il.com>, linux-pci@...r.kernel.org, 
 Phil Elwell <phil@...pberrypi.com>, 
 Broadcom internal kernel review list <bcm-kernel-feedback-list@...adcom.com>, 
 kw@...ux.com, linux-arm-kernel@...ts.infradead.org, 
 devicetree@...r.kernel.org, Bjorn Helgaas <bhelgaas@...gle.com>, 
 Krzysztof Kozlowski <krzk+dt@...nel.org>, 
 Andrea della Porta <andrea.porta@...e.com>
Subject: Re: [PATCH v2 -next 00/11] Add PCIe support for bcm2712


On Tue, 10 Sep 2024 18:18:34 +0300, Stanimir Varbanov wrote:
> Hello,
> 
> Here is a v2 of adding PCIe support for bcm2712 (RPi5), the fisrt
> version can be found at [1].
> 
> v2 is based on linux-next plus latest changes in pcie-brcmstb driver
> [2]. The changes recently made by Jim leaded to a simplified patchset
> for bcm2712 enablement coparing with previous version of this series.
> 
> Noticeable changes are:
> 
>  - Use of msi-range property in the MIP MSI-X controller and DT which
>  make possible to avoid few private DT properties. The other noticeable
>  change is moving of msi-pci-addr private property to a second 'reg'
>  region. I'll appreciate comments on this.
> 
>  - Now the PCIe DT nodes are on separate axi{} simple-bus because adding
>  it on soc{} adds too much churn in the node (Florian).
> 
>  - Added 'quirks' field in pcie_cfg_data to work around an issue (hw bug?)
>  with bridge_reset on bcm2712 SoC.
> 
> regards,
> ~Stan
> 
> [1] https://patchwork.kernel.org/project/linux-pci/cover/20240626104544.14233-1-svarbanov@suse.de/
> [2] https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git/log/?h=controller/brcmstb
> 
> Stanimir Varbanov (11):
>   dt-bindings: interrupt-controller: Add bcm2712 MSI-X DT bindings
>   dt-bindings: PCI: brcmstb: Update bindings for PCIe on bcm2712
>   irqchip: mip: Add Broadcom bcm2712 MSI-X interrupt controller
>   PCI: brcmstb: Expand inbound size calculation helper
>   PCI: brcmstb: Restore CRS in RootCtl after prstn_n
>   PCI: brcmstb: Enable external MSI-X if available
>   PCI: brcmstb: Avoid turn off of bridge reset
>   PCI: brcmstb: Add bcm2712 support
>   PCI: brcmstb: Reuse config structure
>   arm64: dts: broadcom: bcm2712: Add PCIe DT nodes
>   arm64: dts: broadcom: bcm2712-rpi-5-b: Enable PCIe DT nodes
> 
>  .../brcm,bcm2712-msix.yaml                    |  69 ++++
>  .../bindings/pci/brcm,stb-pcie.yaml           |   5 +-
>  .../boot/dts/broadcom/bcm2712-rpi-5-b.dts     |   8 +
>  arch/arm64/boot/dts/broadcom/bcm2712.dtsi     | 166 ++++++++++
>  drivers/irqchip/Kconfig                       |  12 +
>  drivers/irqchip/Makefile                      |   1 +
>  drivers/irqchip/irq-bcm2712-mip.c             | 310 ++++++++++++++++++
>  drivers/pci/controller/pcie-brcmstb.c         | 172 +++++++---
>  8 files changed, 694 insertions(+), 49 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/interrupt-controller/brcm,bcm2712-msix.yaml
>  create mode 100644 drivers/irqchip/irq-bcm2712-mip.c
> 
> --
> 2.35.3
> 
> 
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


New warnings running 'make CHECK_DTBS=y broadcom/bcm2712-rpi-5-b.dtb' for 20240910151845.17308-1-svarbanov@...e.de:

arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dtb: pcie@...000: resets: [[12, 42], [13]] is too short
	from schema $id: http://devicetree.org/schemas/pci/brcm,stb-pcie.yaml#
arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dtb: pcie@...000: reset-names:0: 'rescal' was expected
	from schema $id: http://devicetree.org/schemas/pci/brcm,stb-pcie.yaml#
arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dtb: pcie@...000: reset-names:1: 'bridge' was expected
	from schema $id: http://devicetree.org/schemas/pci/brcm,stb-pcie.yaml#
arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dtb: pcie@...000: reset-names: ['bridge', 'rescal'] is too short
	from schema $id: http://devicetree.org/schemas/pci/brcm,stb-pcie.yaml#
arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dtb: pcie@...000: 'msi-controller' is a required property
	from schema $id: http://devicetree.org/schemas/pci/brcm,stb-pcie.yaml#
arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dtb: pcie@...000: resets: [[12, 43], [13]] is too short
	from schema $id: http://devicetree.org/schemas/pci/brcm,stb-pcie.yaml#
arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dtb: pcie@...000: reset-names:0: 'rescal' was expected
	from schema $id: http://devicetree.org/schemas/pci/brcm,stb-pcie.yaml#
arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dtb: pcie@...000: reset-names:1: 'bridge' was expected
	from schema $id: http://devicetree.org/schemas/pci/brcm,stb-pcie.yaml#
arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dtb: pcie@...000: reset-names: ['bridge', 'rescal'] is too short
	from schema $id: http://devicetree.org/schemas/pci/brcm,stb-pcie.yaml#
arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dtb: pcie@...000: 'msi-controller' is a required property
	from schema $id: http://devicetree.org/schemas/pci/brcm,stb-pcie.yaml#
arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dtb: pcie@...000: resets: [[12, 44], [13]] is too short
	from schema $id: http://devicetree.org/schemas/pci/brcm,stb-pcie.yaml#
arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dtb: pcie@...000: reset-names:0: 'rescal' was expected
	from schema $id: http://devicetree.org/schemas/pci/brcm,stb-pcie.yaml#
arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dtb: pcie@...000: reset-names:1: 'bridge' was expected
	from schema $id: http://devicetree.org/schemas/pci/brcm,stb-pcie.yaml#
arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dtb: pcie@...000: reset-names: ['bridge', 'rescal'] is too short
	from schema $id: http://devicetree.org/schemas/pci/brcm,stb-pcie.yaml#