linux-kernel - Re: [PATCH] staging: greybus: Fix capitalization and punctuation inconsistencies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2024091142-quill-tableful-3c3e@gregkh>
Date: Wed, 11 Sep 2024 15:55:52 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: Johan Hovold <johan@...nel.org>
Cc: Steven Davis <goldside000@...look.com>, hvaibhav.linux@...il.com,
	elder@...nel.org, vireshk@...nel.org, rmfrfs@...il.com,
	dtwlin@...il.com, greybus-dev@...ts.linaro.org,
	linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: greybus: Fix capitalization and punctuation
 inconsistencies

On Mon, Sep 09, 2024 at 02:51:33PM +0200, Johan Hovold wrote:
> On Sun, Sep 01, 2024 at 05:18:59PM -0400, Steven Davis wrote:
> > There were a lot of inconsistencies in outputs and
> > comments, some were properly formatted and
> > capitalized, and some weren't. This patch resolves
> > this by properly formatting the inconsistent comments
> > and outputs.
> > 
> > Signed-off-by: Steven Davis <goldside000@...look.com>
> > ---
> >  drivers/staging/greybus/arche-platform.c | 38 ++++++++++++------------
> >  drivers/staging/greybus/authentication.c |  6 ++--
> >  drivers/staging/greybus/bootrom.c        | 16 +++++-----
> >  drivers/staging/greybus/light.c          | 26 ++++++++--------
> >  drivers/staging/greybus/log.c            | 10 +++----
> >  5 files changed, 48 insertions(+), 48 deletions(-)
> 
> I didn't have time to reply here before Greg picked this one up, but I'm
> gonna ask for this one to be reverted.
> 
> The (core) greybus code uses lower case error messages so this patch is
> introducing an inconsistency instead of addressing one.
> 
> I just sent a revert here:
> 
> 	https://lore.kernel.org/20240909124853.9213-1-johan@kernel.org

Thanks for that, sorry about missing that.

greg k-h