linux-kernel - Re: [PATCH v2] selftests: vDSO: don't include generated headers for chacha test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8d4c1292-1e4d-4d11-b6c2-66dbb5aedb6d@sirena.org.uk>
Date: Wed, 11 Sep 2024 15:12:35 +0100
From: Mark Brown <broonie@...nel.org>
To: "Jason A. Donenfeld" <Jason@...c4.com>
Cc: Aishwarya TCV <aishwarya.tcv@....com>, adhemerval.zanella@...aro.org,
	linux-kernel@...r.kernel.org,
	Naresh Kamboju <naresh.kamboju@...aro.org>
Subject: Re: [PATCH v2] selftests: vDSO: don't include generated headers for
 chacha test

On Wed, Sep 11, 2024 at 03:36:32PM +0200, Jason A. Donenfeld wrote:

> It's not correct to use $(top_srcdir) for generated header files, for
> builds that are done out of tree via O=, and $(objtree) isn't valid in
> the selftests context. Instead, just obviate the need for these
> generated header files by defining empty stubs in tools/include, which
> is the same thing that's done for rwlock.h.

...

> I'll replace the broken commit with this one. I've verified the
> kselftests are fine now, particularly for kvm.

Did you also check perf?  For arm64 it uses the sysregs values though I
don't off hand know if that includes any of the generated values.  I
would expect that KVM will start breaking for arm64 at some point even
if it works for now, there was a desire to replace use of magic numbers
for registers in the tests with defines.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)