linux-kernel - Re: [PATCH] watchdog: rzv2h_wdt: Add missing MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3383bc21-9e51-40c4-8bee-07fc59437434@roeck-us.net>
Date: Wed, 11 Sep 2024 07:32:38 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Prabhakar <prabhakar.csengg@...il.com>,
 Wim Van Sebroeck <wim@...ux-watchdog.org>,
 Stephen Rothwell <sfr@...b.auug.org.au>,
 Geert Uytterhoeven <geert+renesas@...der.be>
Cc: linux-kernel@...r.kernel.org, linux-renesas-soc@...r.kernel.org,
 linux-watchdog@...r.kernel.org,
 Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
Subject: Re: [PATCH] watchdog: rzv2h_wdt: Add missing MODULE_LICENSE tag to
 fix modpost error

On 9/11/24 06:20, Prabhakar wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
> 
> Add the missing `MODULE_LICENSE()` tag to the `rzv2h_wdt` driver, which
> resolves the following modpost error when built as a module:
> 
>      ERROR: modpost: missing MODULE_LICENSE() in drivers/watchdog/rzv2h_wdt.o
> 
> Fixes: f6febd0a30b6 ("watchdog: Add Watchdog Timer driver for RZ/V2H(P)")
> Reported-by: Stephen Rothwell <sfr@...b.auug.org.au>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>

Reviewed-by: Guenter Roeck <linux@...ck-us.net>

> ---
> Hi Wim,
> 
> As `rzv2h_wdt.c` still not in -next maybe we can merge this patch in
> original commit in the watchdog tree?
> 
> Cheers,
> Prabhakar
> ---
>   drivers/watchdog/rzv2h_wdt.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/watchdog/rzv2h_wdt.c b/drivers/watchdog/rzv2h_wdt.c
> index 2da7a631fb2a..1d1b17312747 100644
> --- a/drivers/watchdog/rzv2h_wdt.c
> +++ b/drivers/watchdog/rzv2h_wdt.c
> @@ -270,3 +270,4 @@ static struct platform_driver rzv2h_wdt_driver = {
>   module_platform_driver(rzv2h_wdt_driver);
>   MODULE_AUTHOR("Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>");
>   MODULE_DESCRIPTION("Renesas RZ/V2H(P) WDT Watchdog Driver");
> +MODULE_LICENSE("GPL");