[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZuEL6LhQ8bszGRdk@iZbp1asjb3cy8ks0srf007Z>
Date: Wed, 11 Sep 2024 11:18:00 +0800
From: Qianqiang Liu <qianqiang.liu@....com>
To: davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
pabeni@...hat.com
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Should the return value of the copy_from_sockptr be checked?
Hi,
Should the return value of the copy_from_sockptr in net/socket.c be checked?
The following patch may solve this problem:
diff --git a/net/socket.c b/net/socket.c
index 0a2bd22ec105..6b9a414d01d5 100644
--- a/net/socket.c
+++ b/net/socket.c
@@ -2370,8 +2370,11 @@ int do_sock_getsockopt(struct socket *sock, bool compat, int level,
if (err)
return err;
- if (!compat)
- copy_from_sockptr(&max_optlen, optlen, sizeof(int));
+ if (!compat) {
+ err = copy_from_sockptr(&max_optlen, optlen, sizeof(int));
+ if (err)
+ return -EFAULT;
+ }
ops = READ_ONCE(sock->ops);
if (level == SOL_SOCKET) {
--
Best,
Qianqiang Liu
Powered by blists - more mailing lists