linux-kernel - Re: [PATCH v3 1/3] dt-bindings: display/xlnx/zynqmp-dpsub: Add audio DMAs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <172606795201.325596.766778615878256783.robh@kernel.org>
Date: Wed, 11 Sep 2024 10:19:12 -0500
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Tomi Valkeinen <tomi.valkeinen@...asonboard.com>
Cc: Laurent Pinchart <laurent.pinchart@...asonboard.com>,
	Lars-Peter Clausen <lars@...afoo.de>,
	Maxime Ripard <mripard@...nel.org>, Takashi Iwai <tiwai@...e.com>,
	Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
	Conor Dooley <conor+dt@...nel.org>,
	Anatoliy Klymenko <anatoliy.klymenko@....com>,
	Daniel Vetter <daniel@...ll.ch>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	linux-kernel@...r.kernel.org, Liam Girdwood <lgirdwood@...il.com>,
	dri-devel@...ts.freedesktop.org, Mark Brown <broonie@...nel.org>,
	devicetree@...r.kernel.org, linux-sound@...r.kernel.org,
	Thomas Zimmermann <tzimmermann@...e.de>,
	Vishal Sagar <vishal.sagar@....com>,
	Jaroslav Kysela <perex@...ex.cz>, Rob Herring <robh+dt@...nel.org>,
	Péter Ujfalusi <peter.ujfalusi@...il.com>,
	Michal Simek <michal.simek@....com>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
	linux-arm-kernel@...ts.infradead.org,
	David Airlie <airlied@...il.com>
Subject: Re: [PATCH v3 1/3] dt-bindings: display/xlnx/zynqmp-dpsub: Add audio
 DMAs


On Tue, 10 Sep 2024 14:19:19 +0300, Tomi Valkeinen wrote:
> The DP subsystem for ZynqMP supports audio via two channels, and the DP
> DMA has dma-engines for those channels. For some reason the DT binding
> has not specified those channels, even if the picture included in
> xlnx,zynqmp-dpsub.yaml shows "2 x aud" DMAs.
> 
> This hasn't caused any issues as the drivers have not supported audio,
> and has thus gone unnoticed.
> 
> To make it possible to add the audio support to the driver, add the two
> audio DMAs to the binding. While strictly speaking this is an ABI break,
> there should be no regressions caused by this as we're adding new
> entries at the end of the dmas list, and, after the audio support has
> been added in "arm64: dts: zynqmp: Add DMA for DP audio",  the driver
> will treat the audio DMAs as optional to also support the old bindings.
> 
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@...asonboard.com>
> ---
>  .../devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.yaml    | 10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)
> 

Reviewed-by: Rob Herring (Arm) <robh@...nel.org>