linux-kernel - Re: [PATCH v3 0/2] Properly initialize speed/duplex and remove vDPA config updates

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACGkMEscQWywn67yN7fAaRdWkOZV80RryCvyf_02RDWjrKZMwA@mail.gmail.com>
Date: Wed, 11 Sep 2024 11:42:31 +0800
From: Jason Wang <jasowang@...hat.com>
To: "Michael S. Tsirkin" <mst@...hat.com>
Cc: Carlos Bilbao <carlos.bilbao.osdev@...il.com>, dtatulea@...dia.com, 
	shannon.nelson@....com, sashal@...nel.org, alvaro.karsz@...id-run.com, 
	christophe.jaillet@...adoo.fr, steven.sistare@...cle.com, bilbao@...edu, 
	xuanzhuo@...ux.alibaba.com, johnah.palmer@...cle.com, eperezma@...hat.com, 
	cratiu@...dia.com, virtualization@...ts.linux.dev, 
	linux-kernel@...r.kernel.org, Carlos Bilbao <cbilbao@...italocean.com>
Subject: Re: [PATCH v3 0/2] Properly initialize speed/duplex and remove vDPA
 config updates

On Tue, Sep 10, 2024 at 2:29 PM Michael S. Tsirkin <mst@...hat.com> wrote:
>
> On Wed, Sep 04, 2024 at 10:11:13AM -0500, Carlos Bilbao wrote:
> > From: Carlos Bilbao <cbilbao@...italocean.com>
> >
> > Initialize speed and duplex for virtio_net_config to UNKNOWN (mlx5_vdpa
> > vDPA devices currently do not support VIRTIO_NET_F_SPEED_DUPLEX). Remove
> > ioctl VHOST_VDPA_SET_CONFIG and its related logic as it is not supported;
> > see: https://docs.oasis-open.org/virtio/virtio/v1.3/virtio-v1.3.html
> >
> > Carlos:
> >   vdpa/mlx5: Set speed and duplex of vDPA devices to UNKNOWN
> >   vdpa: Remove ioctl VHOST_VDPA_SET_CONFIG per spec compliance
>
> This will need a rebase. Will apply once you post one.
> Thanks!

Note that I think patch 2 is probably not right as we indeed allow
config write for some device.

Thanks