linux-kernel - Re: [PATCH] cpufreq/amd-pstate-ut: Fix an "Uninitialized variables" issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0af7ec21-d470-4efe-98ec-9b4879575478@amd.com>
Date: Wed, 11 Sep 2024 11:02:03 -0500
From: Mario Limonciello <mario.limonciello@....com>
To: Qianqiang Liu <qianqiang.liu@....com>, ray.huang@....com,
 gautham.shenoy@....com, perry.yuan@....com
Cc: rafael@...nel.org, viresh.kumar@...aro.org, linux-pm@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] cpufreq/amd-pstate-ut: Fix an "Uninitialized variables"
 issue

On 9/10/2024 18:39, Qianqiang Liu wrote:
> Using uninitialized value "mode2" when calling "amd_pstate_get_mode_string".
> Set "mode2" to "AMD_PSTATE_DISABLE" by default.
> 
> Signed-off-by: Qianqiang Liu <qianqiang.liu@....com>
> ---
>   drivers/cpufreq/amd-pstate-ut.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/cpufreq/amd-pstate-ut.c b/drivers/cpufreq/amd-pstate-ut.c
> index c291b3dbec38..f66701514d90 100644
> --- a/drivers/cpufreq/amd-pstate-ut.c
> +++ b/drivers/cpufreq/amd-pstate-ut.c
> @@ -270,7 +270,7 @@ static int amd_pstate_set_mode(enum amd_pstate_mode mode)
>   
>   static void amd_pstate_ut_check_driver(u32 index)
>   {
> -	enum amd_pstate_mode mode1, mode2;
> +	enum amd_pstate_mode mode1, mode2 = AMD_PSTATE_DISABLE;
>   	int ret;
>   
>   	for (mode1 = AMD_PSTATE_DISABLE; mode1 < AMD_PSTATE_MAX; mode1++) {

Acked-by: Mario Limonciello <mario.limonciello@....com>

Much appreciated.  I needed to redo the PR for 6.12 and I added this as 
well.