linux-kernel - Re: [PATCH v3 2/2] of/irq: Use helper to define resources

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZuHCJcTyQvfPl7ai@smile.fi.intel.com>
Date: Wed, 11 Sep 2024 19:15:33 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Vasileios Amoiridis <vassilisamir@...il.com>
Cc: robh@...nel.org, saravanak@...gle.com, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 2/2] of/irq: Use helper to define resources

On Wed, Sep 11, 2024 at 06:02:53PM +0200, Vasileios Amoiridis wrote:
> Resources definition can become simpler and more organised by using the
> dedicated helpers.

...

> -		r->start = r->end = irq;
> -		r->flags = IORESOURCE_IRQ | irq_get_trigger_type(irq);
> -		r->name = name ? name : of_node_full_name(dev);
> +		*r = DEFINE_RES_IRQ_NAMED(irq, name ? name : of_node_full_name(dev));

Hmm... It seems you haven't replied to me why you avoid using Elvis here,
while at it.

Also for both patches you probably want
Suggested-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

> +		r->flags |= irq_get_trigger_type(irq);

-- 
With Best Regards,
Andy Shevchenko