linux-kernel - Re: [PATCH hotfix 6.11] minmax: reduce egregious min/max macro expansion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <827b2d90-d23f-41c8-8e72-ecd5ca9ee534@lunn.ch>
Date: Wed, 11 Sep 2024 18:57:47 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Lorenzo Stoakes <lorenzo.stoakes@...cle.com>
Cc: Hans de Goede <hdegoede@...hat.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Richard Narron <richard@...zen.com>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Mauro Carvalho Chehab <mchehab@...nel.org>,
	Sakari Ailus <sakari.ailus@...ux.intel.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Marcin Wojtas <marcin.s.wojtas@...il.com>,
	Russell King <linux@...linux.org.uk>,
	"David S . Miller" <davem@...emloft.net>,
	Arnd Bergmann <arnd@...nel.org>,
	Linus Torvalds <torvalds@...uxfoundation.org>,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-media@...r.kernel.org, linux-staging@...ts.linux.dev,
	linux-mm@...ck.org, stable@...r.kernel.org
Subject: Re: [PATCH hotfix 6.11] minmax: reduce egregious min/max macro
 expansion

> > I think that you can then also replace clamp_t() with clamp()
> 
> The use of clamp_t() is to avoid egregious macro expansion in
> clamp(). After the series improving min/max the clamp() is probably
> equivalent. But in 5.15 it will likely not be. So this is, in line with the
> purpose of this change, I believe necesasry.

Maybe that should be in the commit message?

	Andrew