linux-kernel - RE: [PATCH v5 2/3] firmware: xilinx: Add Pinctrl Get Attribute ID

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID:
 <LV3PR12MB9260FA686E776F856F4779C8E29B2@LV3PR12MB9260.namprd12.prod.outlook.com>
Date: Wed, 11 Sep 2024 17:10:46 +0000
From: "Thangaraj, Senthil Nathan" <SenthilNathan.Thangaraj@....com>
To: "Potthuri, Sai Krishna" <sai.krishna.potthuri@....com>, Linus Walleij
	<linus.walleij@...aro.org>, "Simek, Michal" <michal.simek@....com>, Rob
 Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor
 Dooley <conor+dt@...nel.org>, "Buddhabhatti, Jay" <jay.buddhabhatti@....com>,
	"Kundanala, Praveen Teja" <praveen.teja.kundanala@....com>, Greg
 Kroah-Hartman <gregkh@...uxfoundation.org>
CC: "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "linux-gpio@...r.kernel.org"
	<linux-gpio@...r.kernel.org>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, "saikrishna12468@...il.com"
	<saikrishna12468@...il.com>, "git (AMD-Xilinx)" <git@....com>
Subject: RE: [PATCH v5 2/3] firmware: xilinx: Add Pinctrl Get Attribute ID

Got it, LGTM thanks.

> -----Original Message-----
> From: Potthuri, Sai Krishna <sai.krishna.potthuri@....com>
> Sent: Monday, September 9, 2024 10:58 PM
> To: Thangaraj, Senthil Nathan <SenthilNathan.Thangaraj@....com>; Linus
> Walleij <linus.walleij@...aro.org>; Simek, Michal <michal.simek@....com>;
> Rob Herring <robh@...nel.org>; Krzysztof Kozlowski <krzk+dt@...nel.org>;
> Conor Dooley <conor+dt@...nel.org>; Buddhabhatti, Jay
> <jay.buddhabhatti@....com>; Kundanala, Praveen Teja
> <praveen.teja.kundanala@....com>; Greg Kroah-Hartman
> <gregkh@...uxfoundation.org>
> Cc: linux-arm-kernel@...ts.infradead.org; linux-kernel@...r.kernel.org; linux-
> gpio@...r.kernel.org; devicetree@...r.kernel.org;
> saikrishna12468@...il.com; git (AMD-Xilinx) <git@....com>
> Subject: RE: [PATCH v5 2/3] firmware: xilinx: Add Pinctrl Get Attribute ID
> 
> Hi Senthil,
> 
> > -----Original Message-----
> > From: Thangaraj, Senthil Nathan <SenthilNathan.Thangaraj@....com>
> > Sent: Monday, September 9, 2024 10:33 PM
> > To: Potthuri, Sai Krishna <sai.krishna.potthuri@....com>; Linus
> > Walleij <linus.walleij@...aro.org>; Simek, Michal
> > <michal.simek@....com>; Rob Herring <robh@...nel.org>; Krzysztof
> > Kozlowski <krzk+dt@...nel.org>; Conor Dooley <conor+dt@...nel.org>;
> > Buddhabhatti, Jay <jay.buddhabhatti@....com>; Kundanala, Praveen Teja
> > <praveen.teja.kundanala@....com>; Greg Kroah-Hartman
> > <gregkh@...uxfoundation.org>
> > Cc: linux-arm-kernel@...ts.infradead.org;
> > linux-kernel@...r.kernel.org; linux-gpio@...r.kernel.org;
> > devicetree@...r.kernel.org; saikrishna12468@...il.com; git
> > (AMD-Xilinx) <git@....com>; Potthuri, Sai Krishna
> > <sai.krishna.potthuri@....com>
> > Subject: RE: [PATCH v5 2/3] firmware: xilinx: Add Pinctrl Get
> > Attribute ID
> >
> > Hi Sai Krishna,
> >
> > Please find my review below.
> >
> > Thanks,
> > Senthil
> >
> > > -----Original Message-----
> > > From: linux-arm-kernel
> > > <linux-arm-kernel-bounces@...ts.infradead.org>
> > > On Behalf Of Sai Krishna Potthuri
> > > Sent: Friday, September 6, 2024 4:01 AM
> > > To: Linus Walleij <linus.walleij@...aro.org>; Simek, Michal
> > > <michal.simek@....com>; Rob Herring <robh@...nel.org>; Krzysztof
> > > Kozlowski <krzk+dt@...nel.org>; Conor Dooley <conor+dt@...nel.org>;
> > > Buddhabhatti, Jay <jay.buddhabhatti@....com>; Kundanala, Praveen
> > > Teja <praveen.teja.kundanala@....com>; Greg Kroah-Hartman
> > > <gregkh@...uxfoundation.org>
> > > Cc: linux-arm-kernel@...ts.infradead.org;
> > > linux-kernel@...r.kernel.org; linux- gpio@...r.kernel.org;
> > > devicetree@...r.kernel.org; saikrishna12468@...il.com; git
> > > (AMD-Xilinx) <git@....com>; Potthuri, Sai Krishna
> > > <sai.krishna.potthuri@....com>
> > > Subject: [PATCH v5 2/3] firmware: xilinx: Add Pinctrl Get Attribute
> > > ID
> > >
> > > Caution: This message originated from an External Source. Use proper
> > > caution when opening attachments, clicking links, or responding.
> > >
> > >
> > > Add Pinctrl Get Attribute ID to the query ids list.
> > >
> > > Signed-off-by: Sai Krishna Potthuri <sai.krishna.potthuri@....com>
> > > ---
> > >  include/linux/firmware/xlnx-zynqmp.h | 1 +
> > >  1 file changed, 1 insertion(+)
> > >
> > > diff --git a/include/linux/firmware/xlnx-zynqmp.h
> > > b/include/linux/firmware/xlnx-zynqmp.h
> > > index d7d07afc0532..3b4ce4ec5d3f 100644
> > > --- a/include/linux/firmware/xlnx-zynqmp.h
> > > +++ b/include/linux/firmware/xlnx-zynqmp.h
> > > @@ -238,6 +238,7 @@ enum pm_query_id {
> > >         PM_QID_PINCTRL_GET_PIN_GROUPS = 11,
> > >         PM_QID_CLOCK_GET_NUM_CLOCKS = 12,
> > >         PM_QID_CLOCK_GET_MAX_DIVISOR = 13,
> > > +       PM_QID_PINCTRL_GET_ATTRIBUTES = 15,
> >
> > Any reason why do you need to skip 14 and use 15 here ?
> This is based on the ID defined in the Xilinx Platform Management Firmware.
> Whatever the ID defined by the Xilinx firmware to handle this functionality, the
> same ID is used here. ID 14 might be used for another query function but Linux
> use cases might not be using it.
> 
> Regards
> Sai Krishna