linux-kernel - Re: [PATCH net-next v2 2/2] net: ethtool: Add support for writing firmware blocks using EPL payload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <76d49fe4-e2b4-43c4-83f9-07796f47ae1d@lunn.ch>
Date: Wed, 11 Sep 2024 19:38:18 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Danielle Ratson <danieller@...dia.com>
Cc: Simon Horman <horms@...nel.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"davem@...emloft.net" <davem@...emloft.net>,
	"edumazet@...gle.com" <edumazet@...gle.com>,
	"kuba@...nel.org" <kuba@...nel.org>,
	"pabeni@...hat.com" <pabeni@...hat.com>,
	"yuehaibing@...wei.com" <yuehaibing@...wei.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Petr Machata <petrm@...dia.com>
Subject: Re: [PATCH net-next v2 2/2] net: ethtool: Add support for writing
 firmware blocks using EPL payload

> Hi Andrew,
> 
> In both cases we transfer the same size of data, which corresponds to the size of the firmware image, to the module.
> Moreover, in both cases the same size of data is passing on the wire, which depends on the wire obligations.
> 
> But, instead of running #n "0103h: Write FW Block LPL" commands (see section 9.7.4 in CMIS 5.2) with up to 128 bytes, we are running #n/16 "0104h: Write FW Block EPL" commands (see section 9.7.5 in CMIS 5.2) with up to 2048 bytes.
> That means that instead of processing #n commands and sending back to the core the status for each one, we do it for only #n/16.

O.K, thanks.

> The standard does not say anything about the I2C layer, but the
> speedup doesn’t lie in that.

What does your hardware do? Can it do 2048 byte I2C bus transfers? Or
is it getting chopped up into smaller chunks?

Thanks
	Andrew