linux-kernel - Re: [PATCH] selftests: kselftest: Use strerror() on nolibc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <449d19f6-5869-43c6-81d3-7f77d4e4d449@linuxfoundation.org>
Date: Wed, 11 Sep 2024 11:41:45 -0600
From: Shuah Khan <skhan@...uxfoundation.org>
To: Thomas Weißschuh <linux@...ssschuh.net>
Cc: zhangjiao2 <zhangjiao2@...s.chinamobile.com>, Willy Tarreau <w@....eu>,
 linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org,
 "Paul E. McKenney" <paulmck@...nel.org>, shuah@...nel.org,
 Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH] selftests: kselftest: Use strerror() on nolibc

On 9/11/24 09:44, Thomas Weißschuh wrote:
> Hi Shuah,
> 
> On 2024-09-11 09:36:50+0000, Shuah Khan wrote:
>> On 9/10/24 22:42, zhangjiao2 wrote:
>>> From: zhang jiao <zhangjiao2@...s.chinamobile.com>
>>>
>>> Nolibc gained an implementation of strerror() recently.
>>> Use it and drop the ifndef.
>>>
>>> Signed-off-by: zhang jiao <zhangjiao2@...s.chinamobile.com>
>>> ---
>>>    tools/testing/selftests/kselftest.h | 8 --------
>>>    1 file changed, 8 deletions(-)
>>>
>>> diff --git a/tools/testing/selftests/kselftest.h b/tools/testing/selftests/kselftest.h
>>> index e195ec156859..29fedf609611 100644
>>> --- a/tools/testing/selftests/kselftest.h
>>> +++ b/tools/testing/selftests/kselftest.h
>>> @@ -373,15 +373,7 @@ static inline __noreturn __printf(1, 2) void ksft_exit_fail_msg(const char *msg,
>>>    static inline __noreturn void ksft_exit_fail_perror(const char *msg)
>>>    {
>>> -#ifndef NOLIBC
>>>    	ksft_exit_fail_msg("%s: %s (%d)\n", msg, strerror(errno), errno);
>>> -#else
>>> -	/*
>>> -	 * nolibc doesn't provide strerror() and it seems
>>> -	 * inappropriate to add one, just print the errno.
>>> -	 */
>>> -	ksft_exit_fail_msg("%s: %d)\n", msg, errno);
>>> -#endif
>>>    }
>>>    static inline __noreturn void ksft_exit_xfail(void)
>>
>> Adding nolibc maintainers for review.
>>
>> Willy and Thomas, please review.
> 
> Acked-by: Thomas Weißschuh <linux@...ssschuh.net>
> 
> I did the same for another kselftests function when introducing
> strerror(). This one was apparently missed or didn't exist yet.
> 
> 


Thank you. Applied to linux-kselftest next for Linux 6.12-rc1.

thanks,
-- Shuah