[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <a3849bc0-000a-4290-b2c3-71a50a750495@gmail.com>
Date: Thu, 12 Sep 2024 02:40:09 +0800
From: Nick Chan <towinchenmi@...il.com>
To: Conor Dooley <conor@...nel.org>
Cc: Hector Martin <marcan@...can.st>, Sven Peter <sven@...npeter.dev>,
Alyssa Rosenzweig <alyssa@...enzweig.io>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
<conor+dt@...nel.org>, "Rafael J . Wysocki" <rafael@...nel.org>,
Viresh Kumar <viresh.kumar@...aro.org>,
Linus Walleij <linus.walleij@...aro.org>,
Wim Van Sebroeck <wim@...ux-watchdog.org>, Guenter Roeck
<linux@...ck-us.net>, Catalin Marinas <catalin.marinas@....com>,
Will Deacon <will@...nel.org>, Lorenzo Pieralisi <lpieralisi@...nel.org>,
Mark Kettenis <kettenis@...nbsd.org>, asahi@...ts.linux.dev,
linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org,
linux-gpio@...r.kernel.org, linux-watchdog@...r.kernel.org,
Konrad Dybcio <konradybcio@...nel.org>,
Ivaylo Ivanov <ivo.ivanov.ivanov1@...il.com>
Subject: Re: [PATCH 01/22] dt-bindings: arm: cpus: Add Apple A7-A11 CPU cores
On 12/9/2024 02:16, Conor Dooley wrote:
> On Wed, Sep 11, 2024 at 04:40:51PM +0800, Nick Chan wrote:
>> Add the following CPU cores:
>>
>> - apple,cyclone: A7 cores
>> - apple,typhoon: A8 cores
>> - apple,twister: A9 cores
>> - apple,hurricane-zephyr: A10 logical cores
>> - apple,monsoon: A11 performance cores
>> - apple,mistral: A11 efficiency cores
>>
>> In the Apple A10, there are physical performance-efficiency cores that
>> forms logical cores to software depending on the current p-state, and
>> only one type of core may be active at one time.
>>
>> Signed-off-by: Nick Chan <towinchenmi@...il.com>
>> ---
>> Documentation/devicetree/bindings/arm/cpus.yaml | 6 ++++++
>> 1 file changed, 6 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/cpus.yaml b/Documentation/devicetree/bindings/arm/cpus.yaml
>> index f308ff6c3532..3959e022079f 100644
>> --- a/Documentation/devicetree/bindings/arm/cpus.yaml
>> +++ b/Documentation/devicetree/bindings/arm/cpus.yaml
>> @@ -89,6 +89,12 @@ properties:
>> - apple,blizzard
>> - apple,icestorm
>> - apple,firestorm
>> + - apple,mistral
>> + - apple,monsoon
>> + - apple,hurricane-zephyr
>> + - apple,twister
>> + - apple,typhoon
>> + - apple,cyclone
>
> Same on this one, can you add these in alphanumerical order, even if the
> existing 3 devices are not in it? You could take the opportunity to
> reshuffle icestorm and firestorm while you're at it.
(Same goes for the watchdog, pinctrl and cluster-cpufreq bindings)
I am not actually sure what is the right thing to do here. It seems that
these bindings are
originally sorted using SoC types (desktop or mobile) and generations.
But then again I have
looked at some other in-tree bindings from asahi, and it seems to be a
mix of alphabetical
and logical sorting in the way mentioned above.
Maybe we can get some clarification from an Asahi Maintainer?
For the soc-level machine compatibles though, I believe that should be
retaining the logical
order instead of trying to use alphabetical order.
>
> Cheers,
> Conor.
>
>> - arm,arm710t
>> - arm,arm720t
>> - arm,arm740t
>> --
>> 2.46.0
>>
Nick Chan
Powered by blists - more mailing lists