[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20240911050435.53156-1-qianqiang.liu@163.com>
Date: Wed, 11 Sep 2024 13:04:37 +0800
From: Qianqiang Liu <qianqiang.liu@....com>
To: xiyou.wangcong@...il.com,
davem@...emloft.net,
edumazet@...gle.com,
kuba@...nel.org,
pabeni@...hat.com
Cc: netdev@...r.kernel.org,
linux-kernel@...r.kernel.org,
Qianqiang Liu <qianqiang.liu@....com>
Subject: [PATCH] net: check the return value of the copy_from_sockptr
We must check the return value of the copy_from_sockptr. Otherwise, it
may cause some weird issues.
Signed-off-by: Qianqiang Liu <qianqiang.liu@....com>
---
net/socket.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/net/socket.c b/net/socket.c
index 0a2bd22ec105..6b9a414d01d5 100644
--- a/net/socket.c
+++ b/net/socket.c
@@ -2370,8 +2370,11 @@ int do_sock_getsockopt(struct socket *sock, bool compat, int level,
if (err)
return err;
- if (!compat)
- copy_from_sockptr(&max_optlen, optlen, sizeof(int));
+ if (!compat) {
+ err = copy_from_sockptr(&max_optlen, optlen, sizeof(int));
+ if (err)
+ return -EFAULT;
+ }
ops = READ_ONCE(sock->ops);
if (level == SOL_SOCKET) {
--
2.39.2
Powered by blists - more mailing lists