linux-kernel - Re: [PATCH] fbdev/xen-fbfront: Assign fb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <69952d52-3c3a-44a0-9288-38b0383d3379@gmx.de>
Date: Wed, 11 Sep 2024 07:59:42 +0200
From: Helge Deller <deller@....de>
To: Jason Andryuk <jandryuk@...il.com>,
 Thomas Zimmermann <tzimmermann@...e.de>, Arnd Bergmann <arnd@...db.de>,
 Sam Ravnborg <sam@...nborg.org>
Cc: xen-devel@...ts.xenproject.org, Jason Andryuk <jason.andryuk@....com>,
 Arthur Borsboom <arthurborsboom@...il.com>, stable@...r.kernel.org,
 linux-fbdev@...r.kernel.org, dri-devel@...ts.freedesktop.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fbdev/xen-fbfront: Assign fb_info->device

On 9/10/24 04:09, Jason Andryuk wrote:
> From: Jason Andryuk <jason.andryuk@....com>
>
> Probing xen-fbfront faults in video_is_primary_device().  The passed-in
> struct device is NULL since xen-fbfront doesn't assign it and the
> memory is kzalloc()-ed.  Assign fb_info->device to avoid this.
>
> This was exposed by the conversion of fb_is_primary_device() to
> video_is_primary_device() which dropped a NULL check for struct device.
>
> Fixes: f178e96de7f0 ("arch: Remove struct fb_info from video helpers")
> Reported-by: Arthur Borsboom <arthurborsboom@...il.com>
> Closes: https://lore.kernel.org/xen-devel/CALUcmUncX=LkXWeiSiTKsDY-cOe8QksWhFvcCneOKfrKd0ZajA@mail.gmail.com/
> Tested-by: Arthur Borsboom <arthurborsboom@...il.com>
> CC: stable@...r.kernel.org
> Signed-off-by: Jason Andryuk <jason.andryuk@....com>

applied to fbdev git tree.

Thanks!
Helge