linux-kernel - Question about config UPROBES and UPROBE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <1a3567d5-e558-351a-c45d-73b2e5a8788c@loongson.cn>
Date: Wed, 11 Sep 2024 14:40:56 +0800
From: Tiezhu Yang <yangtiezhu@...ngson.cn>
To: Masami Hiramatsu <mhiramat@...nel.org>
Cc: linux-trace-kernel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Question about config UPROBES and UPROBE_EVENTS

Hi Masami,

I am a little confused about config UPROBES and UPROBE_EVENTS.
Uprobes is the user-space counterpart to kprobes, I want to do
some small changes:

(1) since config KPROBES can be selectable, just make config UPROBES
     selectable too.

(2) since config KPROBE_EVENTS depends on KPROBES rather than select
     KPROBES, just make config UPROBE_EVENTS depends on UPROBES rather
     than select UPROBES.

Could you please let me know are you OK with the following changes?
If yes, I will send formal patches later.

-- >8 --
diff --git a/arch/Kconfig b/arch/Kconfig
index 975dd22a2dbd..5de2187d3440 100644
--- a/arch/Kconfig
+++ b/arch/Kconfig
@@ -124,7 +124,8 @@ config KPROBES_ON_FTRACE
           optimize on top of function tracing.

  config UPROBES
-       def_bool n
+       bool "Uprobes"
+       default n
         depends on ARCH_SUPPORTS_UPROBES
         help
           Uprobes is the user-space counterpart to kprobes: they
diff --git a/kernel/trace/Kconfig b/kernel/trace/Kconfig
index 721c3b221048..7db0462a5d11 100644
--- a/kernel/trace/Kconfig
+++ b/kernel/trace/Kconfig
@@ -732,10 +732,9 @@ config KPROBE_EVENTS_ON_NOTRACE

  config UPROBE_EVENTS
         bool "Enable uprobes-based dynamic events"
-       depends on ARCH_SUPPORTS_UPROBES
+       depends on UPROBES
         depends on MMU
         depends on PERF_EVENTS
-       select UPROBES
         select PROBE_EVENTS
         select DYNAMIC_EVENTS
         select TRACING

Thanks,
Tiezhu