lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <bbdb74dd2dcd9653a714705d032a69a4bf547418.camel@gmail.com>
Date: Wed, 11 Sep 2024 09:15:00 +0200
From: Nuno Sá <noname.nuno@...il.com>
To: "Rob Herring (Arm)" <robh@...nel.org>, Lars-Peter Clausen
 <lars@...afoo.de>,  Michael Hennerich <Michael.Hennerich@...log.com>,
 Jonathan Cameron <jic23@...nel.org>, Krzysztof Kozlowski
 <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, Michael Auchter
 <michael.auchter@...com>
Cc: linux-iio@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: iio: dac: adi,ad56xx: Fix duplicate
 compatible strings

On Tue, 2024-09-10 at 18:44 -0500, Rob Herring (Arm) wrote:
> adi,ad5686.yaml and adi,ad5696.yaml duplicate all the I2C device
> compatible strings with the exception of "adi,ad5337r". Since
> adi,ad5686.yaml references spi-peripheral-props.yaml, drop the I2C
> devices from it making it only SPI devices. Update the titles to make
> the distinction clear.
> 
> Signed-off-by: Rob Herring (Arm) <robh@...nel.org>
> ---

Reviewed-by: Nuno Sa <nuno.sa@...log.com>

>  .../bindings/iio/dac/adi,ad5686.yaml          | 53 ++++++-------------
>  .../bindings/iio/dac/adi,ad5696.yaml          |  3 +-
>  2 files changed, 19 insertions(+), 37 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml
> b/Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml
> index b4400c52bec3..713f535bb33a 100644
> --- a/Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml
> +++ b/Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml
> @@ -4,7 +4,7 @@
>  $id: http://devicetree.org/schemas/iio/dac/adi,ad5686.yaml#
>  $schema: http://devicetree.org/meta-schemas/core.yaml#
>  
> -title: Analog Devices AD5360 and similar DACs
> +title: Analog Devices AD5360 and similar SPI DACs
>  
>  maintainers:
>    - Michael Hennerich <michael.hennerich@...log.com>
> @@ -12,41 +12,22 @@ maintainers:
>  
>  properties:
>    compatible:
> -    oneOf:
> -      - description: SPI devices
> -        enum:
> -          - adi,ad5310r
> -          - adi,ad5672r
> -          - adi,ad5674r
> -          - adi,ad5676
> -          - adi,ad5676r
> -          - adi,ad5679r
> -          - adi,ad5681r
> -          - adi,ad5682r
> -          - adi,ad5683
> -          - adi,ad5683r
> -          - adi,ad5684
> -          - adi,ad5684r
> -          - adi,ad5685r
> -          - adi,ad5686
> -          - adi,ad5686r
> -      - description: I2C devices
> -        enum:
> -          - adi,ad5311r
> -          - adi,ad5337r
> -          - adi,ad5338r
> -          - adi,ad5671r
> -          - adi,ad5675r
> -          - adi,ad5691r
> -          - adi,ad5692r
> -          - adi,ad5693
> -          - adi,ad5693r
> -          - adi,ad5694
> -          - adi,ad5694r
> -          - adi,ad5695r
> -          - adi,ad5696
> -          - adi,ad5696r
> -
> +    enum:
> +      - adi,ad5310r
> +      - adi,ad5672r
> +      - adi,ad5674r
> +      - adi,ad5676
> +      - adi,ad5676r
> +      - adi,ad5679r
> +      - adi,ad5681r
> +      - adi,ad5682r
> +      - adi,ad5683
> +      - adi,ad5683r
> +      - adi,ad5684
> +      - adi,ad5684r
> +      - adi,ad5685r
> +      - adi,ad5686
> +      - adi,ad5686r
>  
>    reg:
>      maxItems: 1
> diff --git a/Documentation/devicetree/bindings/iio/dac/adi,ad5696.yaml
> b/Documentation/devicetree/bindings/iio/dac/adi,ad5696.yaml
> index 56b0cda0f30a..b5a88b03dc2f 100644
> --- a/Documentation/devicetree/bindings/iio/dac/adi,ad5696.yaml
> +++ b/Documentation/devicetree/bindings/iio/dac/adi,ad5696.yaml
> @@ -4,7 +4,7 @@
>  $id: http://devicetree.org/schemas/iio/dac/adi,ad5696.yaml#
>  $schema: http://devicetree.org/meta-schemas/core.yaml#
>  
> -title: Analog Devices AD5696 and similar multi-channel DACs
> +title: Analog Devices AD5696 and similar I2C multi-channel DACs
>  
>  maintainers:
>    - Michael Auchter <michael.auchter@...com>
> @@ -16,6 +16,7 @@ properties:
>    compatible:
>      enum:
>        - adi,ad5311r
> +      - adi,ad5337r
>        - adi,ad5338r
>        - adi,ad5671r
>        - adi,ad5675r

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ