linux-kernel - Re: [PATCH v2 09/15] timers: Add a warning to usleep_range

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8734m6eiq3.fsf@somnus>
Date: Wed, 11 Sep 2024 09:45:56 +0200
From: Anna-Maria Behnsen <anna-maria@...utronix.de>
To: Joe Perches <joe@...ches.com>, Frederic Weisbecker
 <frederic@...nel.org>, Thomas Gleixner <tglx@...utronix.de>, Jonathan
 Corbet <corbet@....net>
Cc: linux-kernel@...r.kernel.org, Len Brown <len.brown@...el.com>, "Rafael
 J. Wysocki" <rafael@...nel.org>, Andy Whitcroft <apw@...onical.com>
Subject: Re: [PATCH v2 09/15] timers: Add a warning to usleep_range_state()
 for wrong order of arguments

Joe Perches <joe@...ches.com> writes:

> On Wed, 2024-09-11 at 07:13 +0200, Anna-Maria Behnsen wrote:
>> There is a warning in checkpatch script that triggers, when min and max
>> arguments of usleep_range_state() are in reverse order. This check does
>> only cover callsites which uses constants. Move this check into the code as
>> a WARN_ON_ONCE() to also cover callsites not using constants and get rid of
>> it in checkpatch.
>
> I don't disagree that a runtime test is useful
> and relatively cost free.
>
> But checkpatch is for patches.
>
> There's no reason as far as I can tell to remove
> this source code test.
>
> Why make the test runtime only?
>

Sure, we can keep the test in checkpatch as well and I will only add the
runtime check. Then I would change the link to the documentation in
checkpatch into a link to the updated function description. Before I do
any update there, I want to wait for your answer to the other patch of
the queue.

Thanks,

	Anna-Maria