linux-kernel - Re: [PATCH net-next v4 0/6] net: ethernet: ti: am65-cpsw: Add multi queue RX support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <27447854-6a79-4153-a1b3-6ff86911de26@ti.com>
Date: Wed, 11 Sep 2024 13:47:05 +0530
From: MD Danish Anwar <danishanwar@...com>
To: Roger Quadros <rogerq@...nel.org>,
        "David S. Miller"
	<davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
	<kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Siddharth Vadapalli
	<s-vadapalli@...com>,
        Julien Panis <jpanis@...libre.com>,
        Alexei Starovoitov
	<ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Jesper Dangaard
 Brouer <hawk@...nel.org>,
        John Fastabend <john.fastabend@...il.com>
CC: Simon Horman <horms@...nel.org>, Andrew Lunn <andrew@...n.ch>,
        Joe Damato
	<jdamato@...tly.com>, <srk@...com>, <vigneshr@...com>,
        pekka Varis
	<p-varis@...com>, <netdev@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <linux-omap@...r.kernel.org>,
        <bpf@...r.kernel.org>
Subject: Re: [PATCH net-next v4 0/6] net: ethernet: ti: am65-cpsw: Add multi
 queue RX support



On 10/09/24 2:53 pm, Roger Quadros wrote:
> Hi,
> 
> am65-cpsw can support up to 8 queues at Rx. So far we have
> been using only one queue (i.e. default flow) for all RX traffic.
> 
> This series adds multi-queue support. The driver starts with
> 1 RX queue by default. User can increase the RX queues via ethtool,
> e.g. 'ethtool -L ethx rx <N>'
> 
> The series also adds regmap and regfield support to some of the
> ALE registers. It adds Policer/Classifier registers and fields.
> 
> Converting the existing ALE control APIs to regfields can be a separate
> exercise.
> 
> Some helper functions are added to read/write to the Policer/Classifier
> registers and a default Classifier setup function is added that
> routes packets based on their PCP/DSCP priority to different RX queues.
> 
> Signed-off-by: Roger Quadros <rogerq@...nel.org>
> ---
> Changes in v4:
> - Use single macro AM65_CPSW_MAX_QUEUES for both TX and RX queues
>   to simplify code
> - reuse am65_cpsw_get/set_per_queue_coalesce for am65_cpsw_get/set_coalesce.
> - return -EINVAL if unsupported tx/rx_coalesce_usecs in
>   am65_cpsw_set_coalesce.
> - reverse Xmas tree declaration order fixes in cpsw_ale
> - Link to v3: https://lore.kernel.org/r/20240703-am65-cpsw-multi-rx-v3-0-f11cd860fd72@kernel.org
> 
> Changes in v3:
> - code style fixes
> - squashed patches 5 and 6
> - added comment about priority to thread mapping table.
> - Added Reviewed-by Simon Horman.
> - Link to v2: https://lore.kernel.org/r/20240628-am65-cpsw-multi-rx-v2-0-c399cb77db56@kernel.org
> 
> Changes in v2:
> - rebase to net/next
> - fixed RX stall issue during iperf
> - Link to v1: https://lore.kernel.org/r/20240606-am65-cpsw-multi-rx-v1-0-0704b0cb6fdc@kernel.org
> 
> ---
> Roger Quadros (6):
>       net: ethernet: ti: am65-cpsw: Introduce multi queue Rx
>       net: ethernet: ti: cpsw_ale: use regfields for ALE registers
>       net: ethernet: ti: cpsw_ale: use regfields for number of Entries and Policers
>       net: ethernet: ti: cpsw_ale: add Policer and Thread control register fields
>       net: ethernet: ti: cpsw_ale: add policer/classifier helpers and setup defaults
>       net: ethernet: ti: am65-cpsw: setup priority to flow mapping
> 
>  drivers/net/ethernet/ti/am65-cpsw-ethtool.c |  75 +++---
>  drivers/net/ethernet/ti/am65-cpsw-nuss.c    | 388 ++++++++++++++++------------
>  drivers/net/ethernet/ti/am65-cpsw-nuss.h    |  39 +--
>  drivers/net/ethernet/ti/cpsw_ale.c          | 287 ++++++++++++++++++--
>  drivers/net/ethernet/ti/cpsw_ale.h          |  62 ++++-
>  5 files changed, 594 insertions(+), 257 deletions(-)
> ---
> base-commit: bfba7bc8b7c2c100b76edb3a646fdce256392129
> change-id: 20240606-am65-cpsw-multi-rx-fb6cf8dea5eb
> 
> Best regards,

For this series,
Reviewed-by: MD Danish Anwar <danishanwar@...com>

-- 
Thanks and Regards,
Danish