linux-kernel - Re: [PATCH][next][V2] qlcnic: make read-only const array key static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240911084341.GN572255@kernel.org>
Date: Wed, 11 Sep 2024 09:43:41 +0100
From: Simon Horman <horms@...nel.org>
To: Colin Ian King <colin.i.king@...il.com>
Cc: Shahed Shaikh <shshaikh@...vell.com>,
	Manish Chopra <manishc@...vell.com>, GR-Linux-NIC-Dev@...vell.com,
	"David S . Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org, kernel-janitors@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next][V2] qlcnic: make read-only const array key static

On Tue, Sep 10, 2024 at 01:06:35PM +0100, Colin Ian King wrote:
> Don't populate the const read-only array key on the stack at
> run time, instead make it static.
> 
> Signed-off-by: Colin Ian King <colin.i.king@...il.com>
> 
> ---
> 
> V2: re-order declarations for reverse christmas tree layout

Thanks for the update.

Reviewed-by: Simon Horman <horms@...nel.org>