| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20240911093029.3279154-1-vdonnefort@google.com>
Date: Wed, 11 Sep 2024 10:30:16 +0100
From: Vincent Donnefort <vdonnefort@...gle.com>
To: rostedt@...dmis.org, mhiramat@...nel.org,
linux-trace-kernel@...r.kernel.org, maz@...nel.org, oliver.upton@...ux.dev
Cc: kvmarm@...ts.linux.dev, will@...nel.org, qperret@...gle.com,
kernel-team@...roid.com, linux-kernel@...r.kernel.org,
Vincent Donnefort <vdonnefort@...gle.com>
Subject: [PATCH 00/13] Tracefs support for pKVM
The growing set of features supported by the hypervisor in protected
mode necessitates debugging and profiling tools. Tracefs is the
ideal candidate for this task:
* It is simple to use and to script.
* It is supported by various tools, from the trace-cmd CLI to the
Android web-based perfetto.
* The ring-buffer, where are stored trace events consists of linked
pages, making it an ideal structure for sharing between kernel and
hypervisor.
This series introduces a method to create events and to generate them
from the hypervisor (hyp_enter/hyp_exit given as an example) as well as
a Tracefs user-space interface to read them.
A presentation was given on this matter during the tracing summit in
2022. [1]
1. ring-buffer
--------------
To setup the per-cpu ring-buffers, a new interface is created:
ring_buffer_writer: Describes what the kernel needs to know about the
writer, that is, the set of pages forming the
ring-buffer and a callback for the reader/head
swapping (enables consuming read)
ring_buffer_reader(): Creates a read-only ring-buffer from a
ring_buffer_writer.
To keep the internals of `struct ring_buffer` in sync with the writer,
the meta-page is used. It was originally introduced to enable user-space
mapping of the ring-buffer [1]. In this case, the kernel is not the
producer anymore but the reader. The function to read that meta-page is:
ring_buffer_poll_writer():
Update `struct ring_buffer` based on the writer
meta-page. Wake-up readers if necessary.
The kernel has to poll the meta-page to be notified of newly written
events.
2. Tracefs interface
--------------------
The interface is a hypervisor/ folder at the root of the tracefs mount
point. This folder is like an instance and you'll find there a subset
of the regular Tracefs user-space interface:
hypervisor/
buffer_size_kb
trace_clock
trace_pipe
trace_pipe_raw
trace
per_cpu/
cpuX/
trace
trace_pipe
trace_pipe_raw
events/
hypervisor/
hyp_enter/
enable
id
Behind the scenes, kvm/hyp_trace.c must rebuild the tracing hierarchy
without relying on kernel/trace/trace.c. This is due to fundamental
differences:
* Hypervisor tracing doesn't support trace_array's system-specific
features (snapshots, tracers, etc.).
* Logged event formats differ (e.g., no PID in hypervisor
events).
* Buffer operations require specific hypervisor interactions.
3. Events
---------
In the hypervisor, "hyp events" can be generated with trace_<event_name>
in a similar fashion to what the kernel does. They're also created with
similar macros than the kernel (see kvm_hypevents.h)
HYP_EVENT("foboar",
HE_PROTO(void),
HE_STRUCT(),
HE_ASSIGN(),
HE_PRINTK(" ")
)
Despite the apparent similarities with TRACE_EVENT(), those macros
internally differs: they must be used in parallel between the hypervisor
(for the writing part) and the kernel (for the reading part) which makes
it difficult to share anything with their kernel counterpart.
Also, events directory isn't using eventfs.
4. Few limitations:
-------------------
Non consuming reading of the buffer isn't supported (i.e. cat trace ->
-EPERM) due to current the lack of support in the ring-buffer meta-page.
[1] https://tracingsummit.org/ts/2022/hypervisortracing/
[2] https://lore.kernel.org/all/20240510140435.3550353-1-vdonnefort@google.com/
Changes since RFC: https://lore.kernel.org/all/20240805173234.3542917-1-vdonnefort@google.com/
- hypervisor trace clock:
- mult/shift computed in hyp_trace.c.
- Update clock when it deviates from kernel boot clock.
- Add trace_clock file.
- Separate patch for better readability.
- Add a proper reset interface which does not need to teardown the
tracing buffers.
- Return -EPERM on trace access.
- Add per-cpu trace file.
- Automatically teardown and free the tracing buffer when it is empty,
without readers and not currently tracing.
- Show in buffer_size_kb if the buffer is loaded in the hypervisor or
not.
- Extend tests to cover reset and unload.
- CC timekeeping folks on relevant patches
Vincent Donnefort (13):
ring-buffer: Check for empty ring-buffer with rb_num_of_entries()
ring-buffer: Introducing ring-buffer writer
ring-buffer: Expose buffer_data_page material
timekeeping: Add the boot clock to system time snapshot
KVM: arm64: Support unaligned fixmap in the nVHE hyp
KVM: arm64: Add clock support in the nVHE hyp
KVM: arm64: Add tracing support for the pKVM hyp
KVM: arm64: Add hyp tracing to tracefs
KVM: arm64: Add clock for hyp tracefs
KVM: arm64: Add raw interface for hyp tracefs
KVM: arm64: Add trace interface for hyp tracefs
KVM: arm64: Add support for hyp events
KVM: arm64: Add kselftest for tracefs hyp tracefs
arch/arm64/include/asm/kvm_asm.h | 8 +
arch/arm64/include/asm/kvm_define_hypevents.h | 60 ++
arch/arm64/include/asm/kvm_hyp.h | 1 -
arch/arm64/include/asm/kvm_hypevents.h | 41 +
arch/arm64/include/asm/kvm_hypevents_defs.h | 41 +
arch/arm64/include/asm/kvm_hyptrace.h | 37 +
arch/arm64/kernel/image-vars.h | 4 +
arch/arm64/kernel/vmlinux.lds.S | 18 +
arch/arm64/kvm/Kconfig | 9 +
arch/arm64/kvm/Makefile | 2 +
arch/arm64/kvm/arm.c | 6 +
arch/arm64/kvm/hyp/hyp-constants.c | 4 +
arch/arm64/kvm/hyp/include/nvhe/arm-smccc.h | 13 +
arch/arm64/kvm/hyp/include/nvhe/clock.h | 16 +
.../kvm/hyp/include/nvhe/define_events.h | 21 +
arch/arm64/kvm/hyp/include/nvhe/trace.h | 60 ++
arch/arm64/kvm/hyp/nvhe/Makefile | 1 +
arch/arm64/kvm/hyp/nvhe/clock.c | 49 +
arch/arm64/kvm/hyp/nvhe/events.c | 35 +
arch/arm64/kvm/hyp/nvhe/ffa.c | 2 +-
arch/arm64/kvm/hyp/nvhe/hyp-main.c | 85 ++
arch/arm64/kvm/hyp/nvhe/hyp.lds.S | 4 +
arch/arm64/kvm/hyp/nvhe/mm.c | 2 +-
arch/arm64/kvm/hyp/nvhe/psci-relay.c | 14 +-
arch/arm64/kvm/hyp/nvhe/switch.c | 5 +-
arch/arm64/kvm/hyp/nvhe/trace.c | 660 ++++++++++++
arch/arm64/kvm/hyp_events.c | 165 +++
arch/arm64/kvm/hyp_trace.c | 981 ++++++++++++++++++
arch/arm64/kvm/hyp_trace.h | 15 +
include/linux/ring_buffer.h | 108 +-
include/linux/timekeeping.h | 2 +
kernel/time/timekeeping.c | 4 +
kernel/trace/ring_buffer.c | 294 ++++--
tools/testing/selftests/hyp-trace/Makefile | 6 +
tools/testing/selftests/hyp-trace/config | 4 +
.../selftests/hyp-trace/hyp-trace-test | 254 +++++
36 files changed, 2932 insertions(+), 99 deletions(-)
create mode 100644 arch/arm64/include/asm/kvm_define_hypevents.h
create mode 100644 arch/arm64/include/asm/kvm_hypevents.h
create mode 100644 arch/arm64/include/asm/kvm_hypevents_defs.h
create mode 100644 arch/arm64/include/asm/kvm_hyptrace.h
create mode 100644 arch/arm64/kvm/hyp/include/nvhe/arm-smccc.h
create mode 100644 arch/arm64/kvm/hyp/include/nvhe/clock.h
create mode 100644 arch/arm64/kvm/hyp/include/nvhe/define_events.h
create mode 100644 arch/arm64/kvm/hyp/include/nvhe/trace.h
create mode 100644 arch/arm64/kvm/hyp/nvhe/clock.c
create mode 100644 arch/arm64/kvm/hyp/nvhe/events.c
create mode 100644 arch/arm64/kvm/hyp/nvhe/trace.c
create mode 100644 arch/arm64/kvm/hyp_events.c
create mode 100644 arch/arm64/kvm/hyp_trace.c
create mode 100644 arch/arm64/kvm/hyp_trace.h
create mode 100644 tools/testing/selftests/hyp-trace/Makefile
create mode 100644 tools/testing/selftests/hyp-trace/config
create mode 100755 tools/testing/selftests/hyp-trace/hyp-trace-test
base-commit: 8d8d276ba2fb5f9ac4984f5c10ae60858090babc
--
2.46.0.598.g6f2099f65c-goog
Powered by blists - more mailing lists