linux-kernel - Re: [PATCH v3] lib: Export the parsing functions and related data structures of the PLDM library

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID:
 <TYZPR06MB393378C4807373C77856F3FE9D9B2@TYZPR06MB3933.apcprd06.prod.outlook.com>
Date: Wed, 11 Sep 2024 01:32:55 +0000
From: shawn.shao <shawn.shao@...uarmicro.com>
To: Jacob Keller <jacob.e.keller@...el.com>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3] lib: Export the parsing functions and related data
 structures of the PLDM library

> >On 9/9/2024 7:47 PM, Shawn.Shao wrote:
> > From: Shawn Shao <shawn.shao@...uarmicro.com>
> >
> > v1 -> v2: Updated the commit message, added a description
> >       of the changes related to `DeviceUpdateOptionFlags`, etc.
> > v2 -> v3: separate the device_update_flags into another patch
> >
> 
> Minor nit, not worth a re-roll on its own, but the new title does not
> mention pldmfw.

Due to the use of a line break in the email subject, the title was truncated. 
This was my oversight, and I have now corrected it. Thank you!
Please find the corrected patch at the following link:
https://lore.kernel.org/all/20240911012444.1979-1-shawn.shao@jaguarmicro.com/

> > The PLDM library is used to implement firmware upgrades,
> > but the current library functions only support the
> > `pldmfw_flash_image` function to complete a fixed
> > process of parsing, sending data to the backend,
> > and flashing (allowing users to implement custom
> > logic using `pldmfw_ops`). However, this poses
> > significant challenges for device vendors using
> > PLDM for firmware upgrades.
> > The following scenarios are not supported:
> > 1. Only using the PLDM parsing functions, as the
> >    current library does not support this operation.
> > 2. The firmware upgrade process differs from this
> >    fixed flow (the firmware upgrade process may
> >    vary across different vendors).
> >       |-> pldmfw_flash_image
> >               |-> pldm_parse_image
> >                       |-> pldm_parse_header
> >                       |-> pldm_parse_records
> >                       |-> pldm_parse_components
> >                       -> pldm_verify_header_crc
> >               |-> pldm_find_matching_record (xxx_match_record)
> >               |-> pldm_send_package_data (xxx_send_package_data)
> >               |-> pldm_send_component_tables
> (xxx_send_package_data)
> >               |-> pldm_flash_components (xxx_flash_component)
> >               |-> pldm_finalize_update (xxx_finalize_update)
> >
> > Signed-off-by: Shawn Shao <shawn.shao@...uarmicro.com>
> > ---
> 
> 
> Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>


Thanks!