linux-kernel - [PATCH V2] interconnect: qcom: icc-rpmh: probe defer incase of missing QoS clock dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240911094516.16901-1-quic_rlaggysh@quicinc.com>
Date: Wed, 11 Sep 2024 09:45:16 +0000
From: Raviteja Laggyshetty <quic_rlaggysh@...cinc.com>
To: Georgi Djakov <djakov@...nel.org>
CC: Konrad Dybcio <konradybcio@...nel.org>,
        Odelu Kukatla
	<quic_okukatla@...cinc.com>,
        Jeff Johnson <quic_jjohnson@...cinc.com>,
        <linux-arm-msm@...r.kernel.org>, <linux-pm@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>,
        Mike Tipton <quic_mdtipton@...cinc.com>,
        Bjorn Andersson <andersson@...nel.org>
Subject: [PATCH V2] interconnect: qcom: icc-rpmh: probe defer incase of missing QoS clock dependency

Return -EPROBE_DEFER from interconnect provider incase probe defer is
received from devm_clk_bulk_get_all(). This would help in reattempting
the inteconnect driver probe, once the required QoS clocks are
available.

Suggested-by: Bjorn Andersson <andersson@...nel.org>
Signed-off-by: Raviteja Laggyshetty <quic_rlaggysh@...cinc.com>
---
Changes in v2:
 - Removed the qos_clk_required rename change and posted it as separate
   patch.
 - As suggested, dev_err_probe is used for reporting the probe defer
   error message.
---
 drivers/interconnect/qcom/icc-rpmh.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/interconnect/qcom/icc-rpmh.c b/drivers/interconnect/qcom/icc-rpmh.c
index f49a8e0cb03c..adacd6f7d6a8 100644
--- a/drivers/interconnect/qcom/icc-rpmh.c
+++ b/drivers/interconnect/qcom/icc-rpmh.c
@@ -311,6 +311,9 @@ int qcom_icc_rpmh_probe(struct platform_device *pdev)
 		}
 
 		qp->num_clks = devm_clk_bulk_get_all(qp->dev, &qp->clks);
+		if (qp->num_clks == -EPROBE_DEFER)
+			return dev_err_probe(dev, qp->num_clks, "Failed to get QoS clocks\n");
+
 		if (qp->num_clks < 0 || (!qp->num_clks && desc->qos_clks_required)) {
 			dev_info(dev, "Skipping QoS, failed to get clk: %d\n", qp->num_clks);
 			goto skip_qos_config;
-- 
2.39.2