[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <01020191e0b103c3-00fad6e7-f81f-4a76-a75f-1420574f71df-000000@eu-west-1.amazonses.com>
Date: Wed, 11 Sep 2024 10:46:22 +0000
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
To: Fei Shao <fshao@...omium.org>, Matthias Brugger <matthias.bgg@...il.com>
Cc: Conor Dooley <conor+dt@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>,
Rob Herring <robh@...nel.org>, devicetree@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH 05/13] arm64: dts: mediatek: mt8188: Add missing GCE clock
names
Il 09/09/24 13:14, Fei Shao ha scritto:
> Add the missing clock-names property for GCE nodes to fix errors from
> `make CHECK_DTBS=y mediatek/mt8188-evb.dtb`.
I've sent a patch [1] relaxing the requirement for clock-names in the binding.
There's no reason to make clock-names mandatory, as there is and there always
will be one single clock for each GCE mailbox - and also the driver is not
trying to get the clock by name, but rather gets the clock at index 0 anyway.
Please drop this patch.
Cheers,
Angelo
[1]:
https://lore.kernel.org/all/20240911104327.123602-1-angelogioacchino.delregno@collabora.com/
>
> Signed-off-by: Fei Shao <fshao@...omium.org>
> ---
>
> arch/arm64/boot/dts/mediatek/mt8188.dtsi | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8188.dtsi b/arch/arm64/boot/dts/mediatek/mt8188.dtsi
> index 445d30eee2a1..2900d78b7ceb 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8188.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8188.dtsi
> @@ -1316,6 +1316,7 @@ gce0: mailbox@...20000 {
> interrupts = <GIC_SPI 226 IRQ_TYPE_LEVEL_HIGH 0>;
> #mbox-cells = <2>;
> clocks = <&infracfg_ao CLK_INFRA_AO_GCE>;
> + clock-names = "gce";
> };
>
> gce1: mailbox@...30000 {
> @@ -1324,6 +1325,7 @@ gce1: mailbox@...30000 {
> interrupts = <GIC_SPI 228 IRQ_TYPE_LEVEL_HIGH 0>;
> #mbox-cells = <2>;
> clocks = <&infracfg_ao CLK_INFRA_AO_GCE2>;
> + clock-names = "gce";
> };
>
> scp: scp@...00000 {
Powered by blists - more mailing lists