linux-kernel - Re: [PATCH] kbuild: Support separating source and output of the external module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK7LNARw7aRYEfAJsgctJQVhHvc711ARMZDCFAkHeqkRv5nncw@mail.gmail.com>
Date: Wed, 11 Sep 2024 20:36:15 +0900
From: Masahiro Yamada <masahiroy@...nel.org>
To: Jing Leng <3090101217@....edu.cn>
Cc: nathan@...nel.org, nicolas@...sle.eu, corbet@....net, 
	linux-kbuild@...r.kernel.org, linux-doc@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kbuild: Support separating source and output of the
 external module

On Wed, Sep 11, 2024 at 8:20 PM Jing Leng <3090101217@....edu.cn> wrote:
>
> Revert commit "9a0ebe5011f4", originally when compiling external modules,
> the compiled output can be separated from the source code with the
> following command:
>     make -C <kernel_src> O=<kernel_out> src=<module_src> M=<module_out>
> It is used to https://github.com/lengjingzju/cbuild-ng (inc.mod.mk).
>
> But "src" is an internal variable, so this patch adds a variable "S"
> which is specifically used to change the default value of "src".
>
> Fixes: 9a0ebe5011f4 ("kbuild: use $(obj)/ instead of $(src)/ for common pattern rules")
> Signed-off-by: Jing Leng <3090101217@....edu.cn>


NACK.

Always sign, every time I receive a hack like this over and  over again.


-- 
Best Regards
Masahiro Yamada