linux-kernel - Re: [PATCH 8/9] accel/rocket: Add job submission IOCTL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ba285b99-96a6-4fbf-b72e-b264a300ce6f@web.de>
Date: Wed, 11 Sep 2024 14:02:56 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Tomeu Vizoso <tomeu@...euvizoso.net>, linux-media@...r.kernel.org,
 devicetree@...r.kernel.org, dri-devel@...ts.freedesktop.org,
 iommu@...ts.linux.dev, linaro-mm-sig@...ts.linaro.org,
 linux-arm-kernel@...ts.infradead.org, linux-rockchip@...ts.infradead.org,
 Christian König <christian.koenig@....com>,
 Conor Dooley <conor+dt@...nel.org>, Daniel Vetter <daniel@...ll.ch>,
 David Airlie <airlied@...il.com>, Heiko Stübner
 <heiko@...ech.de>, Jörg Rödel <joro@...tes.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, Oded Gabbay <ogabbay@...nel.org>,
 Philipp Zabel <p.zabel@...gutronix.de>, Rob Herring <robh@...nel.org>,
 Robin Murphy <robin.murphy@....com>, Sumit Semwal <sumit.semwal@...aro.org>,
 Thomas Zimmermann <tzimmermann@...e.de>, Will Deacon <will@...nel.org>
Cc: LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 8/9] accel/rocket: Add job submission IOCTL

…
> +++ b/drivers/accel/rocket/rocket_job.h
> @@ -0,0 +1,49 @@
…
> +#ifndef __ROCKET_JOB_H__
> +#define __ROCKET_JOB_H__
…

I suggest to omit leading underscores from such identifiers.
https://wiki.sei.cmu.edu/confluence/display/c/DCL37-C.+Do+not+declare+or+define+a+reserved+identifier

Regards,
Markus