linux-kernel - Re: [PATCH v3 0/2] Add I2C driver for Bosch BMI270 IMU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6e6urdzq5hf6n2ibfxs25b6hi5yccpl35g3neuqwj5ijolonhp@23vgf23pqj7x>
Date: Wed, 11 Sep 2024 08:38:05 -0400
From: Alex Lanzano <lanzano.alex@...il.com>
To: Vasileios Amoiridis <vassilisamir@...il.com>
Cc: Jonathan.Cameron@...wei.com, conor+dt@...nel.org, 
	devicetree@...r.kernel.org, jagathjog1996@...il.com, jic23@...nel.org, krzk+dt@...nel.org, 
	lars@...afoo.de, linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org, 
	nuno.sa@...log.com, ramona.bolboaca13@...il.com, robh@...nel.org, 
	skhan@...uxfoundation.org
Subject: Re: [PATCH v3 0/2] Add I2C driver for Bosch BMI270 IMU

On Wed, Sep 11, 2024 at 12:22:54AM GMT, Vasileios Amoiridis wrote:
> Hi Alex!
> 
> I recently received a review for the code for the BMP280 sensors, and I think
> it applies well to you as well. Since you are using the sleeping functions in
> your code, maybe a comment on top that explains why this value or where you
> found it in the datasheet would be helpful.
> 
> Specifically for the Bosch Sensors, because Bosch's datasheets have either
> hidden or no information at all, and you need to search for stuff in the
> respective C sensor API in the Bosch GitHub.

Thanks for the review! I'll be sure to comment the sleeping functions.

Best regards,
Alex