linux-kernel - Re: [PATCH] nvmem: core: Fix memleak in nvmem_add_cells_from

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2024091112-emotion-unspoken-1d48@gregkh>
Date: Wed, 11 Sep 2024 15:09:22 +0200
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Markus Elfring <Markus.Elfring@....de>
Cc: Ruihai Zhou <zhou.ruihai@...com>, kernel-janitors@...r.kernel.org,
	Markus Schneider-Pargmann <msp@...libre.com>,
	Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] nvmem: core: Fix memleak in nvmem_add_cells_from_dt
 error path

On Wed, Sep 11, 2024 at 03:05:20PM +0200, Markus Elfring wrote:
> …
> > is outside of the valid range, the info.name alloc by kasprintf will
> 
>                                                allocated by kasprintf()?
> 
> 
> > cause memleak. Just free before return from nvmem_add_cells_from_dt
> …
> 
>         a memory leak?                                               ()?
> 
> 
> How do you think about to increase the application of scope-based resource management?
> 
> Regards,
> Markus

Hi,

This is the semi-friendly patch-bot of Greg Kroah-Hartman.

Markus, you seem to have sent a nonsensical or otherwise pointless
review comment to a patch submission on a Linux kernel developer mailing
list.  I strongly suggest that you not do this anymore.  Please do not
bother developers who are actively working to produce patches and
features with comments that, in the end, are a waste of time.

Patch submitter, please ignore Markus's suggestion; you do not need to
follow it at all.  The person/bot/AI that sent it is being ignored by
almost all Linux kernel maintainers for having a persistent pattern of
behavior of producing distracting and pointless commentary, and
inability to adapt to feedback.  Please feel free to also ignore emails
from them.

thanks,

greg k-h's patch email bot