linux-kernel - Re: [PATCH v5 2/3] Documentation: ABI: added filter mode doc in sysfs-bus-iio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VdOjodDaz6J4sWOiT2HHmdXpOPcWeS5kz4e3rB_=gh3xw@mail.gmail.com>
Date: Thu, 12 Sep 2024 17:47:37 +0300
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Ramona Alexandra Nechita <ramona.nechita@...log.com>
Cc: Jonathan Cameron <jic23@...nel.org>, Lars-Peter Clausen <lars@...afoo.de>, 
	Cosmin Tanislav <cosmin.tanislav@...log.com>, 
	Michael Hennerich <Michael.Hennerich@...log.com>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, Nuno Sa <nuno.sa@...log.com>, 
	Andy Shevchenko <andy@...nel.org>, David Lechner <dlechner@...libre.com>, 
	Marcelo Schmitt <marcelo.schmitt@...log.com>, Olivier Moysan <olivier.moysan@...s.st.com>, 
	Dumitru Ceclan <mitrutzceclan@...il.com>, Matteo Martelli <matteomartelli3@...il.com>, 
	João Paulo Gonçalves <joao.goncalves@...adex.com>, 
	Alisa-Dariana Roman <alisadariana@...il.com>, Mike Looijmans <mike.looijmans@...ic.nl>, 
	linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org, 
	devicetree@...r.kernel.org
Subject: Re: [PATCH v5 2/3] Documentation: ABI: added filter mode doc in sysfs-bus-iio

On Thu, Sep 12, 2024 at 3:17 PM Ramona Alexandra Nechita
<ramona.nechita@...log.com> wrote:
>
> The filter mode / filter type property is used for ad4130
> and ad7779 drivers, therefore the ABI doc file for ad4130
> was removed, merging both of them in the sysfs-bus-iio.

...

> +What:          /sys/bus/iio/devices/iio:deviceX/filter_type_available
> +What:          /sys/bus/iio/devices/iio:deviceX/in_voltage-voltage_filter_mode_available
> +KernelVersion: 6.1

I believe I have already commented on this. The commit message keeps
silent about version changes. Why?

> +Contact:       linux-iio@...r.kernel.org
> +Description:
> +               Reading returns a list with the possible filter modes. Options
> +               for the attribute:
> +                       * "sinc3"       - The digital sinc3 filter. Moderate 1st conversion time.
> +                   Good noise performance.
> +                       * "sinc4"       - Sinc 4. Excellent noise performance. Long
> +                       1st conversion time.
> +                       * "sinc5"       - The digital sinc5 filter. Excellent noise performance
> +                       * "sinc4+sinc1" - Sinc4 + averaging by 8. Low 1st conversion
> +                   time.
> +                       * "sinc3+rej60" - Sinc3 + 60Hz rejection.
> +                       * "sinc3+sinc1" - Sinc3 + averaging by 8. Low 1st conversion
> +                   time.
> +                       * "sinc3+pf1"   - Sinc3 + device specific Post Filter 1.
> +                       * "sinc3+pf2"   - Sinc3 + device specific Post Filter 2.
> +                       * "sinc3+pf3"   - Sinc3 + device specific Post Filter 3.
> +                       * "sinc3+pf4"   - Sinc3 + device specific Post Filter 4.

Also, the original file was more verbose for the complex cases, like
"sinc3+pfX", why has this been changed?

-- 
With Best Regards,
Andy Shevchenko