linux-kernel - Re: [PATCH v1 1/1] i2c: synquacer: Fix clock rate retrieval code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7ha475ast6xpzukbbxq5xg4jniyo4t5rujee3m3eejaigi6hry@v4di2uxcxky2>
Date: Thu, 12 Sep 2024 16:49:43 +0200
From: Andi Shyti <andi.shyti@...nel.org>
To: Andy Shevchenko <andy.shevchenko@...il.com>
Cc: Ard Biesheuvel <ardb@...nel.org>, 
	Christophe JAILLET <christophe.jaillet@...adoo.fr>, linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 1/1] i2c: synquacer: Fix clock rate retrieval code

Hi Andy,

On Thu, Sep 12, 2024 at 05:41:05PM GMT, Andy Shevchenko wrote:
> With the devm_clk_get_enabled() the probe will fail on the systems
> that have no clock provided, such as ACPI-based ones.
> 
>     synquacer_i2c SCX0003:00: error -ENOENT: failed to get and enable clock
>     synquacer_i2c SCX0003:00: probe with driver synquacer_i2c failed with error -2
> 
> Fix this by switching to devm_clk_get_optional_enabled() in conjunction with NULL
> check, so we won't overwrite the clock rate from the property.
> 
> Fixes: 55750148e559 ("i2c: synquacer: Fix an error handling path in synquacer_i2c_probe()")
> Reported-by: Ard Biesheuvel <ardb@...nel.org>
> Closes: https://lore.kernel.org/r/CAMj1kXFH+zB_YuUS+vaEpguhuVGLYbQw55VNDCxnBfSPe6b-nw@mail.gmail.com
> Signed-off-by: Andy Shevchenko <andy.shevchenko@...il.com>

you are late, Ard already sent the fix :-)

Thanks,
Andi