linux-kernel - Re: [PATCH v1 02/10] perf: Support discriminator in addr2line

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87plp8hqb8.fsf@linux.intel.com>
Date: Thu, 12 Sep 2024 07:58:19 -0700
From: Andi Kleen <ak@...ux.intel.com>
To: Arnaldo Carvalho de Melo <acme@...nel.org>
Cc: "Steinar H. Gunderson" <sesse@...gle.com>,
  linux-perf-users@...r.kernel.org,  Adrian Hunter
 <adrian.hunter@...el.com>,  Ian Rogers <irogers@...gle.com>,  Namhyung Kim
 <namhyung@...nel.org>,  Linux Kernel Mailing List
 <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1 02/10] perf: Support discriminator in addr2line

Arnaldo Carvalho de Melo <acme@...nel.org> writes:
>
> I noticed that this is under:
>
> #elif defined(HAVE_LIBBFD_SUPPORT)
>
> That isn't built by default due to licensing issues, i.e. we only build
> it if BUILD_NONDISTRO=1 is selected on the make command line, see:
>
> tools/perf/Makefile.config +943

Yes I know. I ran into this when my perf report runs were suddenly incredibly
slow until I figured out how to set this flag.

It's sad how theoretical lawyerneering breaks perfectly fine code.

At least I'm fine with whatever legal risk this causes.

>
> And we have the patch below now, can we try to use it instead so that at
> some point we can remove the libbpf support?

I also support the external addr2line.

But yes need to support the LLVM version too. I'll look into that.

As a side note. I always disliked the LLVM dependencies, these
libraries/packages are gigantic and traditionally unstable in
interface. It would be better to use a sane small library as a
replacement like https://github.com/ianlancetaylor/libbacktrace

-Andi