linux-kernel - Re: [PATCH 2/2] pm: cpupower: Makefile: better support cross-compiling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0f8df90f-007a-483e-83ce-df8ff0e99791@linuxfoundation.org>
Date: Thu, 12 Sep 2024 09:21:22 -0600
From: Shuah Khan <skhan@...uxfoundation.org>
To: "Peng Fan (OSS)" <peng.fan@....nxp.com>, Thomas Renninger
 <trenn@...e.com>, Shuah Khan <shuah@...nel.org>,
 "John B. Wyatt IV" <jwyatt@...hat.com>, John Kacur <jkacur@...hat.com>,
 "open list:CPU POWER MONITORING SUBSYSTEM" <linux-pm@...r.kernel.org>,
 open list <linux-kernel@...r.kernel.org>
Cc: Peng Fan <peng.fan@....com>, Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH 2/2] pm: cpupower: Makefile: better support
 cross-compiling

On 9/11/24 19:38, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@....com>

Improve subject line. "better support cross-compiling" doesn't
tell me much. "Allow overriding cross-compiling env params" would
is a better subject line for this patch.

> 
> Allow overridding the envs, this will be easier to user Yocto

"Allow overriding the cross-comple env parameters to make it
easier for Yactor users."

Then add what it is like now and how this change helps.

spelling "overridding"?. Run checkpatch on patches before sending.

> cross-compiler toolchains to build cpupower with only two steps:
> 
> source (toolchain path)/environment-setup-armv8a-poky-linux
> make
> 

What steps do you have to take without this change? Include that
in the changelog

> Signed-off-by: Peng Fan <peng.fan@....com>
> ---
>   tools/power/cpupower/Makefile | 12 ++++++------
>   1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/tools/power/cpupower/Makefile b/tools/power/cpupower/Makefile
> index 6c02f401069e..e2a48af6fa2a 100644
> --- a/tools/power/cpupower/Makefile
> +++ b/tools/power/cpupower/Makefile
> @@ -86,12 +86,12 @@ INSTALL_SCRIPT = ${INSTALL} -m 644
>   # If you are running a cross compiler, you may want to set this
>   # to something more interesting, like "arm-linux-".  If you want
>   # to compile vs uClibc, that can be done here as well.
> -CROSS = #/usr/i386-linux-uclibc/usr/bin/i386-uclibc-
> -CC = $(CROSS)gcc
> -LD = $(CROSS)gcc
> -AR = $(CROSS)ar
> -STRIP = $(CROSS)strip
> -RANLIB = $(CROSS)ranlib
> +CROSS ?= #/usr/i386-linux-uclibc/usr/bin/i386-uclibc-
> +CC ?= $(CROSS)gcc
> +LD ?= $(CROSS)gcc
> +AR ?= $(CROSS)ar
> +STRIP ?= $(CROSS)strip
> +RANLIB ?= $(CROSS)ranlib
>   HOSTCC = gcc
>   MKDIR = mkdir
>   

Send v2 with cover-letter to make easier for reviewers.

thanks,
-- Shuah